Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang tidy errors #654

Open
cieslarmichal opened this issue Jun 15, 2024 · 5 comments
Open

fix clang tidy errors #654

cieslarmichal opened this issue Jun 15, 2024 · 5 comments
Labels
good first issue Good for newcomers high priority High priority

Comments

@cieslarmichal
Copy link
Owner

https://github.com/cieslarmichal/faker-cxx/actions/runs/9528652077/job/26266591173

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Jun 15, 2024
@00thirdeye00
Copy link
Contributor

can you give some more information about this issue?

@cieslarmichal
Copy link
Owner Author

When running clang-tidy it gives a lot of errors, I am not familiar with clang tidy much but it's static analysis of the code,
It would improve our code quality. First we can add clang tidy config, for example ref its also issue for that: #617

@cieslarmichal
Copy link
Owner Author

and clang tidy runs in continous integration with github workflow but it's turned off so it doesn't fail - running but fails does not fail entire pipelines

@cieslarmichal cieslarmichal added the high priority High priority label Jun 27, 2024
@00thirdeye00
Copy link
Contributor

and clang tidy runs in continous integration with github workflow but it's turned off so it doesn't fail - running but fails does not fail entire pipelines

unclear?

@cieslarmichal
Copy link
Owner Author

check the pipeline output I added in issue description, there are errors that need to be resolved, for now we skip them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers high priority High priority
Projects
None yet
Development

No branches or pull requests

2 participants