Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change file names to match google file names convention #713

Open
cieslarmichal opened this issue Jun 23, 2024 · 8 comments
Open

change file names to match google file names convention #713

cieslarmichal opened this issue Jun 23, 2024 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

file naming convention

@00thirdeye00
Copy link
Contributor

@cieslarmichal there are few suggestions in the guide. It would be helpful if you also share your suggestion on file name convention. I personally prefer underscore type.

@cieslarmichal
Copy link
Owner Author

I can assign you to this issue but lets do that after release v2, so refactoring namespaces first

@cieslarmichal
Copy link
Owner Author

Yeah it could be with underscores

@cieslarmichal
Copy link
Owner Author

I prefer camelCase but its not cpp standard I think

@cieslarmichal
Copy link
Owner Author

So dashes or underscores, we can decide later

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Jun 27, 2024
@cieslarmichal
Copy link
Owner Author

we can go with undescores

@00thirdeye00
Copy link
Contributor

So we modify names for all the files?

@cieslarmichal
Copy link
Owner Author

yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants