Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move internal helper functions to common files #766

Closed
cieslarmichal opened this issue Jul 1, 2024 · 0 comments · Fixed by #778
Closed

move internal helper functions to common files #766

cieslarmichal opened this issue Jul 1, 2024 · 0 comments · Fixed by #778
Labels
good first issue Good for newcomers high priority High priority

Comments

@cieslarmichal
Copy link
Owner

There are couple of methods in Helper.h API file that are not meant to be library API functions but only for internal module usage.

The only functions we want to export are:

  • arrayElement (all overloads)
  • weightedArrayElement

All the remaining functions should be moved out to some file in common directory.
@cieslarmichal cieslarmichal added good first issue Good for newcomers high priority High priority labels Jul 1, 2024
Mehdibenhadjkhelifa added a commit to Mehdibenhadjkhelifa/faker-cxx that referenced this issue Jul 4, 2024
@Mehdibenhadjkhelifa
Moved unwanted public functions from the Helper.h file cieslarmichal#766
9a06dd8
Mehdibenhadjkhelifa added a commit to Mehdibenhadjkhelifa/faker-cxx that referenced this issue Jul 4, 2024
@Mehdibenhadjkhelifa
Refactor:Moved unwanted public functions from Helper.h cieslarmichal#766
b284a78
Mehdibenhadjkhelifa added a commit to Mehdibenhadjkhelifa/faker-cxx that referenced this issue Jul 4, 2024
@Mehdibenhadjkhelifa
Refactor:Moved unwanted public functions from Helper.h (cieslarmichal…
b020978 
…#766)
@cieslarmichal cieslarmichal linked a pull request Jul 4, 2024 that will close this issue
refactor: moved unwanted public functions from Helper.h (#766) #778
Merged
cieslarmichal pushed a commit that referenced this issue Jul 4, 2024
@Mehdibenhadjkhelifa
refactor: moved unwanted public functions from Helper.h (#766) (#778)
cd3bc68 
* Refactor:Moved unwanted public functions from Helper.h (#766)

* Removed unwanted commits from the AlgoHelper.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers high priority High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: moved unwanted public functions from Helper.h (#766) Mehdibenhadjkhelifa/faker-cxx
1 participant
@cieslarmichal