Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize error messages #60

Open
clearloop opened this issue Feb 23, 2022 · 0 comments
Open

Optimize error messages #60

clearloop opened this issue Feb 23, 2022 · 0 comments

Comments

@clearloop
Copy link
Owner

@hao-lee that may be true but it is almost irrelevant to this issue. The error message implies the program is not handling the leetcode response correctly and thus it should be fixed.

We could close this issue then the next new user who comes along and hits this error will likely do exactly what the error message tells him, i.e come here and raise another new bug. Is that what we want?

Originally posted by @bulletmark in #57 (comment)
@152334H 152334H mentioned this issue May 18, 2022
Merged
clearloop pushed a commit that referenced this issue May 20, 2022
@152334H
patches for #60 and #56 (#68)
2b373c0 
* add graphql query for user info

* add parser for graphql user info

* return `CookieError` when leetcode rejects exec/test `Run`

* add the `is_session_bad` method to somewhat-accurately determine when a LEETCODE_SESSION becomes invalid

* When json parsing fails, if the underlying request requires user authentication, use `is_session_bad()` to check if LEETCODE_SESSION is valid.

* get rid of ZWSPs in problem descriptions (see #56)

* add Error::PremiumError

* throw PremiumError when locked questions are queried for details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clearloop