Introduce configurable pbkdf2 iteration limit #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbbot
reviewed
Dec 5, 2023
|
Not currently. That's a good idea tho. The |
jasnell
force-pushed
the
jsnell/configurable-pbkdf2-iteration-limit
branch
2 times, most recently
from
36ceaae
to
974e3cb
Compare
kentonv
reviewed
Dec 8, 2023
kentonv
reviewed
Dec 8, 2023
jasnell
force-pushed
the
jsnell/configurable-pbkdf2-iteration-limit
branch
from
974e3cb
to
6980ce0
Compare
|
Updated to:
|
kentonv
reviewed
Dec 10, 2023
jasnell
force-pushed
the
jsnell/configurable-pbkdf2-iteration-limit
branch
3 times, most recently
from
804c596
to
c5b4190
Compare
jasnell
commented
Dec 15, 2023
jasnell
force-pushed
the
jsnell/configurable-pbkdf2-iteration-limit
branch
2 times, most recently
from
7f5bd89
to
3d9b90b
Compare
kentonv
reviewed
Dec 18, 2023
kentonv
reviewed
Dec 18, 2023
kentonv
reviewed
Dec 18, 2023
jasnell
force-pushed
the
jsnell/configurable-pbkdf2-iteration-limit
branch
3 times, most recently
from
f321bb2
to
b5bbf5a
Compare
Introduces the ability for workerd embedders to configure the max iteration limit for KDFs. Removes the limit for workerd by default. Keeps the current limit of 100,000 when not configured.
jasnell
force-pushed
the
jsnell/configurable-pbkdf2-iteration-limit
branch
from
b5bbf5a
to
12bc98a
Compare
harrishancock
approved these changes
Dec 21, 2023
kentonv
approved these changes
Dec 22, 2023
| @@ -1251,6 +1255,12 @@ Worker::Script::~Script() noexcept(false) { | |||
| impl = nullptr; | |||
| } | |||
|
|
|||
| const Worker::Isolate& Worker::Isolate::from(jsg::Lock& js) { | |||
| auto ptr = js.v8Isolate->GetData(3); | |||
There was a problem hiding this comment.
We should define an enum somewhere of our embedder data indices so we don't accidentally reuse noe.
There was a problem hiding this comment.
Agreed. Already had a note to introduce that in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the ability for workerd embedders to configure the max iteration limit for KDFs. Removes the limit for workerd by default. Keeps the current limit of 100,000 when not configured.
Refs: #1346