Implement memory tracking for Blob/File/Streams #1608
Conversation
jasnell
changed the title
jasnell
force-pushed
the
jsnell/more-meory-tracker
branch
2 times, most recently
from
a9982b1
to
94da874
Compare
jasnell
force-pushed
the
jsnell/basics-memory-tracker
branch
from
dbd624a
to
dbe4e03
Compare
jasnell
force-pushed
the
jsnell/more-meory-tracker
branch
from
94da874
to
f5dbaa7
Compare
jasnell
force-pushed
the
jsnell/basics-memory-tracker
branch
from
dbe4e03
to
d84952a
Compare
jasnell
force-pushed
the
jsnell/more-meory-tracker
branch
from
f5dbaa7
to
8729a72
Compare
jasnell
force-pushed
the
jsnell/basics-memory-tracker
branch
3 times, most recently
from
736599d
to
fd52869
Compare
jasnell
force-pushed
the
jsnell/more-meory-tracker
branch
from
8729a72
to
13de7bd
Compare
| KJ_SWITCH_ONEOF(ownData) { | ||
| KJ_CASE_ONEOF(data, kj::Array<byte>) { | ||
| tracker.trackField("ownData", data); | ||
| } | ||
| KJ_CASE_ONEOF(data, jsg::Ref<Blob>) { | ||
| tracker.trackField("ownData", data); | ||
| } | ||
| } |
There was a problem hiding this comment.
It would be convenient if there were a way to call trackField with a kj::OneOf<S, T, ...> where there is an impl for trackField for each of them. Perhaps it's not worth the hassle to save a little bit of boilerplate.
But maybe you could make a concept Trackable with T::trackField(tracker, name, value) and then define tracker.trackField<Trackable T> to call T::trackField. Then maybe you can define OneOf<Trackable S, Trackable T, Trackable U>::trackField or something?
There was a problem hiding this comment.
I'd considered adding that but I think I prefer separating it out like this in order to give a bit more control over how things are tracked. In some cases, it won't need to be tracked at all, in other cases it make use trackField(...) for one and trackFieldWithSize(...) for others.
No description provided.