Granular e2e caching #6201
Granular e2e caching #6201
Conversation
|
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9809434507/npm-package-wrangler-6201You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6201/npm-package-wrangler-6201Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9809434507/npm-package-wrangler-6201 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9809434507/npm-package-create-cloudflare-6201 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9809434507/npm-package-cloudflare-kv-asset-handler-6201npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9809434507/npm-package-miniflare-6201npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9809434507/npm-package-cloudflare-pages-shared-6201npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9809434507/npm-package-cloudflare-vitest-pool-workers-6201Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
penalosa
force-pushed
the
penalosa/granular-e2e-caching
branch
from
b14e4f3
to
51d01a7
Compare
| * As such, we run the `test:e2e` turbo task multiple times—once per e2e test file | ||
| * with different arguments, ensuring that each file's tests can be cached individually. |
| // Ignore other files in the e2e directory (the README, for instance) | ||
| if (file.endsWith(".test.ts")) { | ||
| tasks.add( | ||
| `pnpm test:e2e --log-order=stream --summarize --filter wrangler --concurrency 1 -- run ./e2e/${file}` |
There was a problem hiding this comment.
Perhaps we could run the build task once at at the start of the run, and then use the --only flag here to avoid dumping all the build output out each time (even though it is full turbo)?
What this PR solves / how to test
Turbo only supports caching on the individual task level, but for Wrangler's e2e tests we want to support caching on a more granular basis—at the file level.
As such, this PR constructs multiple turbo tasks—one per e2e test file, ensuring that each file's tests can be cached individually.
Because Turbo ignores the cache when
package.jsonchanges, we can't generate thesepackage.jsonscripts on the fly in CI, and so we require them to be commited to the repository. Since this is easy to mess up, this PR adds a script to lintturbo.json, the rootpackage.json, and Wrangler'spackage.jsonto ensure everything is set up as intended.The intended flow here is that CI will run
pnpm test:e2e:wrangler, which will trigger turbo to run an individual task for each Wrangler e2e test file. These tasks are defined in the rootturbo.json, and correspond to scripts in the Wrangler package. We ensure there's no accidental task name collision across packages by adding--filter wranglerto the turbo command, to make it only run tasks in the Wrangler package.An example of the benefit this gives us are these two runs:
This e2e test run failed in
dev-with-resources.test.ts, but passed `dev-env.test.tsOn a re-run, the previous
dev-env.test.tssuccess was cached, speeding up the test runAuthor has addressed the following