Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sstable: clean up two/single level iterator init #3653

Closed
RaduBerinde opened this issue Jun 11, 2024 · 1 comment
Closed

sstable: clean up two/single level iterator init #3653

RaduBerinde opened this issue Jun 11, 2024 · 1 comment

Comments

@RaduBerinde
Copy link
Member

RaduBerinde commented Jun 11, 2024

The twoLevelIterator initialization code repeats most of the singleLevelIterator initialization code. Sometimes the two code paths unintentionally diverge (e.g. in 23.2/24.1 one used a preallocated read handle and one didn't).

This issue tracks cleaning up this initialization code - the common parts should be extracted out and reused. The singleLevelIterator fields should be initialized from the single level iterator code, not directly from the two-level code.

Jira issue: PEBBLE-34

@RaduBerinde
Copy link
Member Author

Fixed by #3738.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant