Fixes bug #350 #376
Open
Fixes bug #350 #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,7 +110,9 @@ public static String getRepeatString(Context context, Resources r, EventRecurren | |||
| if(dayNumber == RecurrencePickerDialogFragment.LAST_NTH_DAY_OF_WEEK){ | |||
| dayNumber = 5; | |||
| } | |||
| details = mMonthRepeatByDayOfWeekStrs[weekday][dayNumber - 1]; | |||
| if (dayNumber > 0) { | |||
There was a problem hiding this comment.
This just prevents the exception - we would have a "monthly > on the same day every month" return a "monthly > on the {n}th {weekday} of the month" string.
|
@carrizo - I believe a cleaner way to fix this would be to make I made the following changes to fix this issue. Give it a shot and let me know if you run into any issues.
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves bug #350
I did reproduce the error described by @Rx2TF which throws this exception:
java.lang.ArrayIndexOutOfBoundsException: length=5; index=-1Looks like
EventRecurrence#parse()method is leaving some garbage data in theEventRecurrence#bydayfield. This can be reproduced callingparse()two times, one with a weekly recurrence and then with a monthly recurrence; after this, thebydayfield keeps some data from the first call.I didn't solve the root problem in
EventRecurrenceclass because it looks like I can easily break something there.