-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Improve failed login attempts management #196
Comments
Thanks for your input, and sorry for the late reply! Regarding the proposed options, here are my remarks/questions:
|
@Goalfair I have added a separate issue to address your point 3 (see issue linked to above) to better be able to track this individual item. |
Thanks for the reminder. Regarding the list of failed logins I am suggesting an option to delete these logs manually via the Joomla dashboard (without having to edit the database) - basically a button or similar on the same page as the list. The icing on the cake would be some additional settings like "delete entries which are older than X days" or "delete entries containing certain IP/username/source". But I guess this would be a bit too much. The advanced options with the auto-delete settings I have found, I guess this would allow me to manually delete entries as well, for example by setting it to 1 week temporarily, then changing it back to 0? Maybe instead of a dropdown you should allow the user to type a number. As you mentioned the "inline help" is disabled by default (should be enabled by default IMO). Issue number 2 seems to be working (or I was missing something before), Issue number 3 is a suggestion to move the single setting (show lines), which is now in "Logs" to either "Settings" or Failed logins" (after all the list of failed login attempts is the "log" this setting is related to). I guess what I am trying to say is that in general the options and settings are a bit all over the place right now - most of them can be found in the plugin-settings, however there is no mention of their whereabouts in the component interface/menu (where an average user would probably look for them). Instead there is a settings menu item, which is mostly empty, and probably should either simply contain a link to the plugin settings or the plugin settings should be moved there. |
I see. I guess a button to trigger a "delete entries older than..." functionality could be useful; as well as a pointer to the setting for automatic deletion of old entries!
I haven't explicitly tested this but it should work, yes.
I'll consider it for the rewrite, see below.
I think you are misunderstanding something there - the "Show lines" option under Logs really only affects how many lines of the log file are shown.
I hear you - and there is an issue for improving this, but I unfortunately haven't found the time yet to tackle it! |
@Goalfair with the release of 1.5.1, the last open thing not covered by any other issue is a better way to clean up entries; to track this separately, and to avoid confusion that would occur if we reuse this already quite lenghty issue for that, I've created a separate entry for this, see #214. |
(Joomla 4)
The text was updated successfully, but these errors were encountered: