Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to send SIGKILL? #136

Open
frankstratton opened this issue May 21, 2015 · 5 comments
Open

option to send SIGKILL? #136

frankstratton opened this issue May 21, 2015 · 5 comments

Comments

@frankstratton
Copy link

I have a process that doesn't always respond to the SIGTERM signal and remains running; however invoker shuts down and loses track of this PID leaving an orphaned process around; I've used foreman/forego in the past and it tries to send a SIGTERM, waits a while and then issues SIGKILL on any remaining processes before stopping which cleans up everything correctly. Is it possible to do the same with invoker?

@nisanthchunduru
Copy link
Contributor

We can add a stop_strategy option (inspired by a similar option in https://github.com/kostya/eye)

[someprocess]
command = someprocess
# Send a TERM signal. Wait for 20 seconds.
# If the process is still alive, send a KILL signal.
stop_strategy = "TERM, 20, KILL"

@iffyuva Any ideas?

@frankstratton
Copy link
Author

Something like that would be great for my use case!

@swanandp
Copy link

swanandp commented Nov 9, 2015

I think this should be added to the CLI, i.e. invoker signal sidekiq USR1

@gnufied
Copy link
Contributor

gnufied commented Jan 20, 2016

It already is implemented and has been there since very beginning:

invoker remove sidekiq -s 9

Which will remove sidekiq with signal 9. However when you will Invoker and it quits, all processes are attempted to be killed via TERM signal.

@swanandp
Copy link

swanandp commented Aug 8, 2016

@gnufied I was thinking, instead of just 9, invoker should act as a shim for process commands, e.g it would be useful to send SIGTTIN to a process, and not remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants