Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question text as a label #95

Open
bnadav opened this issue Jan 11, 2017 · 1 comment
Open

Question text as a label #95

bnadav opened this issue Jan 11, 2017 · 1 comment

Comments

@bnadav
Copy link

bnadav commented Jan 11, 2017

Hi all,
The question text is rendered in the different answers partials using a common instruction:

<%= f.label :answer_text, answer.question.question_text %>

This results in a markup that looks like

<label for="attempt_1_answer_text">How are you ?</label>

This is a bit weird since there is no accompanying input element named 'attempt_1_answer_text'.
Also this label does not contain any answer text but rather a question text.

Maybe this label should be replaced by a span or a div element, with a more descriptive id attribute.

@stale
Copy link

stale bot commented Aug 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs for another 14 days. Thank you for your contributions.

@stale stale bot added the stale/wontfix label Aug 28, 2019
@stale stale bot closed this as completed Sep 11, 2019
@iffyuva iffyuva reopened this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants