This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Lesly update name instance #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rspraymond
approved these changes
May 10, 2023
|
🤖 OpenAI Chat with 🤖 OpenAI Bot (
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
289
to
+291
| if (summarizeResp === '') { | ||
| info('summarize: nothing obtained from openai') | ||
| summariesFailed.push(`${filename} (nothing obtained from openai)`) | ||
| info('summarize: nothing fetched from RedRover') | ||
| summariesFailed.push(`${filename} (nothing fetched from RedRover)`) |
There was a problem hiding this comment.
🤖 OpenAI
Replace the log message to maintain consistency with other log messages.
Suggested change
| if (summarizeResp === '') { | |
| info('summarize: nothing obtained from openai') | |
| summariesFailed.push(`${filename} (nothing obtained from openai)`) | |
| info('summarize: nothing fetched from RedRover') | |
| summariesFailed.push(`${filename} (nothing fetched from RedRover)`) | |
| info('summarize: nothing fetched from RedRover for ' + filename) | |
| summariesFailed.push(`${filename} (nothing fetched from RedRover)`) |
Comment on lines
313
to
+315
| } catch (e: any) { | ||
| warning(`summarize: error from openai: ${e as string}`) | ||
| summariesFailed.push(`${filename} (error from openai: ${e as string})})`) | ||
| warning(`summarize: error from RedRover: ${e as string}`) | ||
| summariesFailed.push(`${filename} (error from RedRover: ${e as string})})`) |
There was a problem hiding this comment.
🤖 OpenAI
Maintain consistency in log messages and error handling.
Suggested change
| } catch (e: any) { | |
| warning(`summarize: error from openai: ${e as string}`) | |
| summariesFailed.push(`${filename} (error from openai: ${e as string})})`) | |
| warning(`summarize: error from RedRover: ${e as string}`) | |
| summariesFailed.push(`${filename} (error from RedRover: ${e as string})})`) | |
| warning(`summarize: error from RedRover for ${filename}: ${e as string}`) | |
| summariesFailed.push(`${filename} (error from RedRover: ${e as string})`) |
Comment on lines
354
to
356
| if (summarizeResp === '') { | ||
| warning('summarize: nothing obtained from openai') | ||
| warning('summarize: nothing fetched from RedRover') | ||
| } else { |
There was a problem hiding this comment.
🤖 OpenAI
Update the log message for consistency.
Suggested change
| if (summarizeResp === '') { | |
| warning('summarize: nothing obtained from openai') | |
| warning('summarize: nothing fetched from RedRover') | |
| } else { | |
| warning('summarize: nothing fetched from RedRover for final response') |
Comment on lines
367
to
369
| if (summarizeFinalResponse === '') { | ||
| info('summarize: nothing obtained from openai') | ||
| info('summarize: nothing fetched from RedRover') | ||
| } |
There was a problem hiding this comment.
🤖 OpenAI
Update the log message for consistency.
Suggested change
| if (summarizeFinalResponse === '') { | |
| info('summarize: nothing obtained from openai') | |
| info('summarize: nothing fetched from RedRover') | |
| } | |
| info('summarize: nothing fetched from RedRover for final response') |
Comment on lines
377
to
379
| if (releaseNotesResponse === '') { | ||
| info('release notes: nothing obtained from openai') | ||
| info('release notes: nothing fetched from RedRover') | ||
| } else { |
There was a problem hiding this comment.
🤖 OpenAI
Update the log message for consistency.
Suggested change
| if (releaseNotesResponse === '') { | |
| info('release notes: nothing obtained from openai') | |
| info('release notes: nothing fetched from RedRover') | |
| } else { | |
| info('release notes: nothing fetched from RedRover') |
Comment on lines
590
to
592
| if (response === '') { | ||
| info('review: nothing obtained from openai') | ||
| info('review: nothing fetched from RedRover') | ||
| reviewsFailed.push(`${filename} (no response)`) |
There was a problem hiding this comment.
🤖 OpenAI
Update the log message for consistency.
Suggested change
| if (response === '') { | |
| info('review: nothing obtained from openai') | |
| info('review: nothing fetched from RedRover') | |
| reviewsFailed.push(`${filename} (no response)`) | |
| info('review: nothing fetched from RedRover for ' + filename) | |
| reviewsFailed.push(`${filename} (nothing fetched from RedRover)`) |
Comment on lines
375
to
383
| {} | ||
| ) | ||
| if (releaseNotesResponse === '') { | ||
| info('release notes: nothing obtained from openai') | ||
| info('release notes: nothing fetched from RedRover') | ||
| } else { | ||
| let message = '### Summary by OpenAI\n\n' | ||
| let message = '### Summary by RedRover\n\n' | ||
| message += releaseNotesResponse | ||
| try { | ||
| await commenter.updateDescription( |
There was a problem hiding this comment.
🤖 OpenAI
In line 380, change the summary message to include "RedRover" instead of "OpenAI".
Suggested change
| {} | |
| ) | |
| if (releaseNotesResponse === '') { | |
| info('release notes: nothing obtained from openai') | |
| info('release notes: nothing fetched from RedRover') | |
| } else { | |
| let message = '### Summary by OpenAI\n\n' | |
| let message = '### Summary by RedRover\n\n' | |
| message += releaseNotesResponse | |
| try { | |
| await commenter.updateDescription( | |
| let message = '### Summary by RedRover\n\n' | |
| message += releaseNotesResponse | |
| try { | |
| await commenter.updateDescription( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by OpenAI
New Feature:
Refactor: