Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for basic_auth #11

Open
simplesteph opened this issue Mar 7, 2017 · 3 comments
Open

Support for basic_auth #11

simplesteph opened this issue Mar 7, 2017 · 3 comments

Comments

@simplesteph
Copy link
Contributor

thoughts about supporting basic_auth ?
Basically I'm thinking of VIRTUAL_BASIC_AUTH=admin:hashedpassword by leveraging apache2-utils. Each container could optionally have that variable which would allow us to generate the htpassword dynamically at /etc/nginx/htpassw/$VIRTUAL_HOST

@lucaschain
Copy link
Contributor

Maybe there should be a dynamic way to add any directives to the config file passing the key and the value to the env var

@codesuki
Copy link
Owner

codesuki commented Mar 8, 2017

Having basic auth seems useful!

For dynamically adding things I would prefer a way to specify your own template and be done with it. That seems easier to maintain too (user perspective).

I am currently very busy but in about 2 weeks I hope to have more time. Maybe I can find some time in between to add some things. I appreciate your feedback.

@codesuki
Copy link
Owner

codesuki added a commit to codesuki/ecs-nginx-proxy that referenced this issue Jul 27, 2017
Allowing individual server settings to be configured using environment variables

Implements codesuki/ecs-gen#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants