New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal to queue waiters that no more events will be happening #15

Open

doc-hex opened this issue Feb 25, 2019 · 0 comments

Labels

bug

Contributor

doc-hex commented Feb 25, 2019 •

edited

Loading

When blocking on the queue of messages from a subscribe command, if the connection break, there will never be more events.

make the caller aware of that somehow?
alternative: called must timeout and test connection is alive
better: restart the subscribe after reconnecting, and keep going
would be best if an async generator was used instead of queues

doc-hex added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment