Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CANParser: canValid check doesn’t work if there's no messages to update #467

Open
adeebshihadeh opened this issue Nov 13, 2021 · 0 comments
Open

CANParser: canValid check doesn’t work if there's no messages to update #467

adeebshihadeh opened this issue Nov 13, 2021 · 0 comments
Labels
bug

Comments

@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Nov 13, 2021 •
edited
Loading

The issue really seems to be the CAN parser architecture. Half of it is in C++ and the other half is in the cython wrapper. We should just move the whole thing into C++ and make the cython a thin wrapper.
@adeebshihadeh adeebshihadeh changed the title CANParser: canValid check doesn’t work once it’s been valid CANParser: canValid check doesn’t work if there's no messages to update Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adeebshihadeh