Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honda DBC cleanup #496

Open
adeebshihadeh opened this issue Jan 18, 2022 · 2 comments
Open

Honda DBC cleanup #496

adeebshihadeh opened this issue Jan 18, 2022 · 2 comments
Labels

Comments

@adeebshihadeh
Copy link
Contributor

Ideally, we can use a single DBC for all Hondas, like we do with many of the more recent car ports. This can be done incrementally by doing the following:

  • merging DBCs
  • using common, universal signals when possible
  • abstracting out repeated definitions into common DBCs
@sshane sshane mentioned this issue Jan 28, 2022
7 tasks
@sshane
Copy link
Contributor

sshane commented Jan 28, 2022

  • See if LAT_ACCEL under KINEMATICS on 145 is also available on 148 for cars using 145. The LAT_ACCEL signal is defined in the same location in the message
  • Fix duplicate gear signals defined
  • A lot of these messages are common in bosch vehicles, possible unify:
    • DOORS_STATUS
    • STANDSTILL
    • GEARBOX
    • GAS_PEDAL_2

@sshane
Copy link
Contributor

sshane commented Jan 28, 2022

Notes about common signals:

  • DOORS_STATUS:
  • Identical: honda_civic_hatchback_ex_2017_can, honda_civic_sedan_16_diesel_2019_can, honda_crv_ex_2017_can, honda_insight_ex_2019_can
  • Missing (using SCM_FEEDBACK): honda_crv_hybrid_2019_can, honda_accord_2018_can, acura_rdx_2020_can
  • GAS_PEDAL_2: Not used in openpilot
  • STEERING_CONTROL:

Common messages:

  • Common for _bosch_2020 and _honda_2017: VSA_STATUS, STEER_MOTOR_TORQUE, STANDSTILL, ENGINE_DATA, POWERTRAIN_DATA, WHEEL_SPEEDS, VEHICLE_DYNAMICS

  • Common for _bosch_2020 and _bosch_2018: ADJACENT_RIGHT_LANE_LINE_2, KINEMATICS, STEERING_CONTROL, BOSCH_SUPPLEMENTAL_1, BRAKE_HOLD, ENGINE_DATA, POWERTRAIN_DATA, STEER_STATUS, VSA_STATUS, EPB_STATUS, VEHICLE_DYNAMICS, LEFT_LANE_LINE_1, LEFT_LANE_LINE_2, RIGHT_LANE_LINE_1, RIGHT_LANE_LINE_2, ADJACENT_LEFT_LANE_LINE_1, ADJACENT_LEFT_LANE_LINE_2, ADJACENT_RIGHT_LANE_LINE_1, ADJACENT_RIGHT_LANE_LINE_2, SCM_BUTTONS, CAR_SPEED, ACC_HUD, CRUISE, SCM_FEEDBACK, CAMERA_MESSAGES, STALK_STATUS, STALK_STATUS_2, XXX_16

  • Common between all base DBCs (but not all use/would cause superset): ACC_CONTROL, ACC_CONTROL_ON,

  • Common between all base DBCs: STEER_MOTOR_TORQUE, WHEEL_SPEEDS, ROUGH_WHEEL_SPEED, SEATBELT_STATUS, LKAS_HUD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants