Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make can_valid consider checksums and counters #594

Open
2 tasks
sshane opened this issue Apr 21, 2022 · 0 comments
Open
2 tasks

Make can_valid consider checksums and counters #594

sshane opened this issue Apr 21, 2022 · 0 comments
Labels
bug

Comments

@sshane
Copy link
Contributor

sshane commented Apr 21, 2022

In this segment (6f63165f17c0e270|2022-03-19--23-09-55--92), a Genesis had a controls mismatch due to the car sending a message with an invalid checksum so panda stopped allowing messages but we don't check this in the CAN parser.

  • Consider checksums and counters (need flags to ignore checksums in certain cases? eg. legacy HKG)
  • Add checksum for Hyundai
@sshane sshane added the bug label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sshane