Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependence on cereal #825

Open
adeebshihadeh opened this issue Apr 21, 2023 · 2 comments · May be fixed by #934
Open

Remove dependence on cereal #825

adeebshihadeh opened this issue Apr 21, 2023 · 2 comments · May be fixed by #934
Labels
cleanup

Comments

@adeebshihadeh
Copy link
Contributor

Replace the CANParser's inputs that use cereal::CanData; will need to be done carefully to avoid a large hit to performance.
@adeebshihadeh
Copy link
Contributor Author

@deanlee want to look into this? I'm thinking we make or use an existing struct from opendbc that represents a CAN message, then we write a fast cython function in openpilot to go from cereal's CAN struct to opendbc's struct

@deanlee
Copy link
Contributor

deanlee commented Sep 5, 2023

sure,working on this

@deanlee deanlee linked a pull request Sep 5, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CANParser: remove dependence on cereal deanlee/opendbc
2 participants
@deanlee @adeebshihadeh