UAR-1502 Make 'property name or number' field optional #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* data entry in this field is now optional for the Update and Remove journeys * a value must still be entered if on the Registration journey Change is for a spike - no unit-tests added
mwestacott
requested review from
markpit,
mattch1,
dlloyd1-ch,
HatiDev and
makhtar-ch
mwestacott
commented
May 1, 2024
| }; | ||
|
|
||
| export const checkPresenceOfPropertyNameOrNumber = (propertyNameOrNumber: string, req) => { | ||
| if (propertyNameOrNumber === undefined || propertyNameOrNumber === "") { |
There was a problem hiding this comment.
I copied the approach taken for the 'email' field here, but if we do ever implement this, we may wish to trim the value too before testing it.
|
looks ok to me |
markpit
reviewed
May 2, 2024
| export const overseas_entity_address_validations = (errors: ErrorMessagesOptional = defaultOptionalErrorMessages) => { | ||
| errors = { ...defaultOptionalErrorMessages, ...errors }; | ||
| return [ | ||
| body("principal_address_property_name_number") |
There was a problem hiding this comment.
seeing as this returns an a list of validators, some might be shared with the other lists, could we have a common list and use ... to import the common validations into the list mixed with the specific validations for that field/page, or wold that mean refactoring all the address validations?
There was a problem hiding this comment.
Don't know, but a sensible suggestion. We should investigate if this becomes a 'real' changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://companieshouse.atlassian.net/browse/UAR-1502
Change description
Change is for a spike - no unit-tests added
Work checklist
Merge instructions
We are committed to keeping commit history clean, consistent and linear. To achieve this, this commit should be structured as follows:
and contain the following structural elements:
BREAKING CHANGE:introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type,fix:andfeat:are allowed, for examplebuild:,chore:,ci:,docs:,style:,refactor:,perf:,test:, and others,BREAKING CHANGE: <description>may be provided.