chore(net): add type constraint for get/set_socket_option

compio-rs · Aug 27, 2024 · 148f3ac · 148f3ac
1 parent b1ed765
commit 148f3ac
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 6 deletions.
diff --git a/compio-net/src/socket.rs b/compio-net/src/socket.rs
@@ -324,7 +324,7 @@ impl Socket {
     }
 
     #[cfg(unix)]
-    pub unsafe fn get_socket_option<T>(&self, level: i32, name: i32) -> io::Result<T> {
+    pub unsafe fn get_socket_option<T: Copy>(&self, level: i32, name: i32) -> io::Result<T> {
         let mut value: MaybeUninit<T> = MaybeUninit::uninit();
         let mut len = size_of::<T>() as libc::socklen_t;
         syscall!(libc::getsockopt(
@@ -342,7 +342,7 @@ impl Socket {
     }
 
     #[cfg(windows)]
-    pub unsafe fn get_socket_option<T>(&self, level: i32, name: i32) -> io::Result<T> {
+    pub unsafe fn get_socket_option<T: Copy>(&self, level: i32, name: i32) -> io::Result<T> {
         let mut value: MaybeUninit<T> = MaybeUninit::uninit();
         let mut len = size_of::<T>() as i32;
         syscall!(
@@ -363,7 +363,12 @@ impl Socket {
     }
 
     #[cfg(unix)]
-    pub unsafe fn set_socket_option<T>(&self, level: i32, name: i32, value: &T) -> io::Result<()> {
+    pub unsafe fn set_socket_option<T: Copy>(
+        &self,
+        level: i32,
+        name: i32,
+        value: &T,
+    ) -> io::Result<()> {
         syscall!(libc::setsockopt(
             self.socket.as_raw_fd(),
             level,
@@ -375,7 +380,12 @@ impl Socket {
     }
 
     #[cfg(windows)]
-    pub unsafe fn set_socket_option<T>(&self, level: i32, name: i32, value: &T) -> io::Result<()> {
+    pub unsafe fn set_socket_option<T: Copy>(
+        &self,
+        level: i32,
+        name: i32,
+        value: &T,
+    ) -> io::Result<()> {
         syscall!(
             SOCKET,
             windows_sys::Win32::Networking::WinSock::setsockopt(

diff --git a/compio-net/src/udp.rs b/compio-net/src/udp.rs
@@ -321,7 +321,7 @@ impl UdpSocket {
     /// # Safety
     ///
     /// The caller must ensure `T` is the correct type for `level` and `name`.
-    pub unsafe fn get_socket_option<T>(&self, level: i32, name: i32) -> io::Result<T> {
+    pub unsafe fn get_socket_option<T: Copy>(&self, level: i32, name: i32) -> io::Result<T> {
         self.inner.get_socket_option(level, name)
     }
 
@@ -330,7 +330,12 @@ impl UdpSocket {
     /// # Safety
     ///
     /// The caller must ensure `T` is the correct type for `level` and `name`.
-    pub unsafe fn set_socket_option<T>(&self, level: i32, name: i32, value: &T) -> io::Result<()> {
+    pub unsafe fn set_socket_option<T: Copy>(
+        &self,
+        level: i32,
+        name: i32,
+        value: &T,
+    ) -> io::Result<()> {
         self.inner.set_socket_option(level, name, value)
     }
 }