Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong discriminator is freezed #3

Open
Kanbe-Kotori opened this issue Sep 18, 2023 · 1 comment
Open

wrong discriminator is freezed #3

Kanbe-Kotori opened this issue Sep 18, 2023 · 1 comment

Comments

@Kanbe-Kotori
Copy link

Kanbe-Kotori commented Sep 18, 2023

In L468 of gan_aug_cifar_sm.py, the model that should be frozen is discriminator_aug, while the one that is actually frozen is discriminator. Obviously, the discriminator does not appear below, while discriminator_aug not only appears, but also be updated by g_loss, so I would like to know whether the "Freeze D" mentioned in the proposed algorithm is implemented correctly?

This problem seems also occur in the code of GANs corresponding to other datasets.

@conditionWang
Copy link
Owner

Thanks for pointing this out. We just uploaded the old version of unfreezing the discriminator. We have updated the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants