Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update objects when metadata changed #26

Open
mynomoto opened this issue Jun 29, 2016 · 4 comments
Open

Update objects when metadata changed #26

mynomoto opened this issue Jun 29, 2016 · 4 comments

Comments

@mynomoto
Copy link
Contributor

I'm using :cache-control metadata for caching purposes but confetti doesn't update objects when the file has not changed and the metadata has. Not sure if it should but it would be nice if it did ;-)
Fell free to close it if this is not a reasonable feature for the library.

@martinklepsch martinklepsch changed the title Don't update objects when metadata changed Update objects when metadata changed Jun 29, 2016
@martinklepsch
Copy link
Member

martinklepsch commented Jun 29, 2016

All of the syncing is done in the confetti/s3-deploy project. There we're retrieving object summaries which do not contain metadata. This makes diffing on metadata hard. There's an issue in the s3-deploy project to implement a flag to retrieve full object metadata as basis for syncing: confetti-clj/s3-deploy#10

@martinklepsch
Copy link
Member

@mynomoto I updated the individual-diff branch mentioned in that issue, if you feel like pulling it across the finish line you're more than welcome to! :)

@mynomoto
Copy link
Contributor Author

That was quick! I will take a look on the branch. Thanks!

@mynomoto
Copy link
Contributor Author

I'm back to deploying static websites, which means back to confetti 😄
I thought about it from another perspective. If confetti is managing the bucket then adding a force sync option would avoid the need for this feature and the implications on sync performance from what I saw on confetti-clj/s3-deploy#10
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants