Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman 4.2 has renamed "play kube" to "kube play" with an alias for "play kube" #456

Closed
richm opened this issue Jul 20, 2022 · 5 comments
Closed
Labels
bug Something isn't working enhancement New feature or request

Comments

@richm
Copy link
Contributor

richm commented Jul 20, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

In podman 4.2, the command play kube has been renamed to kube play with an alias for play kube. The containers.podman.podman_play module should detect which version of podman is being used, and use either play kube or kube play depending on the version e.g. at https://github.com/containers/ansible-podman-collections/blob/master/plugins/modules/podman_play.py#L143
Note that podman will continue to provide the alias play kube for some time, so this probably isn't urgent.

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):

Version of the containers.podman collection:
Either git commit if installed from git: git show --summary
Or version from ansible-galaxy if installed from galaxy: ansible-galaxy collection list | grep containers.podman

(paste your output here)

Output of ansible --version:

(paste your output here)

Output of podman version:

(paste your output here)

Output of podman info --debug:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman):

(paste your output here)

Playbok you run with ansible (e.g. content of playbook.yaml):

(paste your output here)

Command line and output of ansible run with high verbosity

Please NOTE: if you submit a bug about idempotency, run the playbook with --diff option, like:

ansible-playbook -i inventory --diff -vv playbook.yml

(paste your output here)

Additional environment details (AWS, VirtualBox, physical, etc.):

@sshnaidm
Copy link
Member

Yeah, good point. Also they added new things there, so probably it might affect the whole module.

@sshnaidm sshnaidm added bug Something isn't working enhancement New feature or request labels Jul 21, 2022
@fsdrw08
Copy link

fsdrw08 commented Jan 23, 2023

Yeah, good point. Also they added new things there, so probably it might affect the whole module.

I would suggest create a new module call podman_kube_play independent to the old one.

@sshnaidm
Copy link
Member

@fsdrw08 probably it's a good idea, a lot of changes came in.

@nishipy
Copy link
Contributor

nishipy commented Mar 28, 2023

According to the release note of Podman v4.3.0, podman generate kube was also renamed to podman kube generate. Thanks to aliases, the old commands still work apparently.

The podman generate kube and podman play kube commands have been renamed to podman kube generate and podman kube play to group Kubernetes-related commands. Aliases have been added to ensure the old command names still function.

@sshnaidm
Copy link
Member

It was fixed in #727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants