Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: All tax categories and shipping categories showing on variant edit page #3557

Open
white-lukas opened this issue Jul 1, 2024 · 1 comment

Comments

@white-lukas
Copy link

What happened?

Description

I have 2 tax categories and 2 product types, each tax category is setup to be only available for 1 product type,
But when editing a product, still both tax categories are available to select as there hasn't been done any filtering in to query those categories (https://github.com/craftcms/commerce/blob/5.x/src/base/Purchasable.php#L1067)

Steps to reproduce

  1. create different product types
  2. Add tax categories and make them available for a single product type
  3. all tax categories are still selectable

Expected behavior

Only the tax categories that are available for the product type should be shown

Actual behavior

all tax categories are show and selectable

Craft CMS version

5.2.4.1

Craft Commerce version

5.0.11.1

PHP version

8.3.8

Operating system and version

Ubuntu 24.04

Database type and version

mysql 8.0

Image driver and version

No response

Installed plugins and versions

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants