Why delete entrypoint.sh ?

[remixmabix]

Support guidelines

• I've read the support guidelines

I've found a bug and checked that ...

• ... the documentation does not mention anything about my problem
• ... there are no open or closed issues that are related to my problem

Description

Hello I liked the entrypoint.sh because I could specify :

client min protocol = NT1
server min protocol = NT1
ntlm auth = ntlmv1-permitted

Now I don't get the init file point

Expected behaviour

retro compat please ?

Actual behaviour

entrypoint is misplaced

Steps to reproduce

...

Docker info

...

Docker Compose config

No response

Logs

...

Additional info

No response

[crazy-max]

entrypoint is misplaced

It has changed since switch to s6-overlay in #85 which does not need an entrypoint script as the base s6-alpine image already has one: https://github.com/crazy-max/docker-alpine-s6/blob/aa655e9d8a090907690f244af93be90a8963ce75/Dockerfile#L256

Hello I liked the entrypoint.sh because I could specify :

client min protocol = NT1
server min protocol = NT1
ntlm auth = ntlmv1-permitted

I guess you were mounting a custom entrypoint.sh? If so you should not as it tampers the container lifecycle. Instead you can set smbd command options like: #77 (comment)

But with switch to s6-overlay I don't think you can do this anymore. Maybe I could allow passing additional flags to the process.

Have you tried making changes in the yaml config?:

global:
  - "client min protocol = NT1"
  - "server min protocol = NT1"
  - "ntlm auth = ntlmv1-permitted"

[crazy-max]

Also if what you want with NT1 is service discovery, you can use https://github.com/crazy-max/docker-samba#service-discovery-for-windows instead.

[remixmabix]

I'm running it into a container in a kubernetes cluster, for redundancy,
I struggled to find the config file but you're right with the global options it seems working.

I also tried to modify it from the Dockerfile at the armv8 build stage :
For who wants :

• COPY ./01-config.sh /etc/cont-init.d/01-config.sh

Maybe it should be explicit in the repo if we want to add something else for those who are not familiar with s6 / overlay or add new features like ? btrfs ? ipfs ?

Thanks, you can close this ticket.

[crazy-max]

• COPY ./01-config.sh /etc/cont-init.d/01-config.sh

Maybe it should be explicit in the repo if we want to add something else for those who are not familiar with s6 / overlay or add new features like ? btrfs ? ipfs ?

If you want to fork and make your own changes feel free to do so but don't think it should be documented here. Also like I said, we could allow additional args being passed to smbd, I would not be against that.

Thanks, you can close this ticket.

👍