Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Error in RecorderWorker.encodeWAV #25

Open
jakelewis3d opened this issue Mar 12, 2018 · 0 comments
Open

Possible Error in RecorderWorker.encodeWAV #25

jakelewis3d opened this issue Mar 12, 2018 · 0 comments

Comments

@jakelewis3d
Copy link

line 134: view.setUint32(4, 32 + samples.length * 2, true);

Shouldn't this be 36 rather than 32?
on line 128 you assign a buffer:
var buffer = new ArrayBuffer(44 + samples.length * 2);
and write 8 bytes into it, so it would figure that the next length would be 8 bytes smaller, ie 36.
And from a quick count there does appear to be 36 bytes written prior to the
Also see http://soundfile.sapp.org/doc/WaveFormat/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant