Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing prefixes for PH #166

Open
achowdhury7 opened this issue Jun 4, 2019 · 3 comments
Open

Missing prefixes for PH #166

achowdhury7 opened this issue Jun 4, 2019 · 3 comments
Labels
missing validation data data for some prefix/country is missing in the souce

Comments

@achowdhury7
Copy link

achowdhury7 commented Jun 4, 2019

The following number formats are returned as invalid:
+63 904-XXX-XXXX, +63 911-XXX-XXXX, +63 913-XXX-XXXX, +63 924-XXX-XXXX, +63 931-XXX-XXXX, +63 941-XXX-XXXX, +63 944-XXX-XXXX, +63 945-XXX-XXXX, +63 961-XXX-XXXX, +63 965-XXX-XXXX, +63 966-XXX-XXXX, +63 967-XXX-XXXX, +63 970-XXX-XXXX, +63 978-XXX-XXXX, +63 981-XXX-XXXX

An issue has been created on Google phonelibnumber's issuetracker for this: https://issuetracker.google.com/issues/134374016

@daddyz
Copy link
Owner

daddyz commented Jun 10, 2019

@achowdhury7 I updated the data from google libphonenumber. Since the issue is marked as fixed, I guess the fix is also applied to my gem. Check version 0.6.35

@achowdhury7
Copy link
Author

achowdhury7 commented Jun 17, 2019

Hi @daddyz
The following prefixes still don't work:
904, 913, 924, 941, 944, 970

Can you please help me with these?
Thanks!

@daddyz
Copy link
Owner

daddyz commented Jun 27, 2019

Google are referencing wikipedia for PH prefixes, maybe you should try to update that page and add additional comment to your issue in google libphonenumber, since they wrote that can't accept "not an official source" which is a bit strange. Just reference this updated page there

@daddyz daddyz added the missing validation data data for some prefix/country is missing in the souce label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing validation data data for some prefix/country is missing in the souce
Projects
None yet
Development

No branches or pull requests

2 participants