Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Fix importer parsing errors #12

Open
daem-on opened this issue Jul 27, 2022 · 2 comments
Open

☂️ Fix importer parsing errors #12

daem-on opened this issue Jul 27, 2022 · 2 comments

Comments

@daem-on
Copy link
Owner

daem-on commented Jul 27, 2022

Umbrella issue for #11, #9, #7

The wtherion importer for TH2 files makes some assumptions based on the thbook specifications, some of which are incorrect.
Not everything follows the same patterns and maybe the whole option parser needs to be rewritten.

daem-on added a commit that referenced this issue Jul 27, 2022
Hopefully more robust than previously
@CaverBruce
Copy link

CaverBruce commented Nov 30, 2022

Checking beta version
image

Imported to WT beta a th2 created by XTherion, saved in WT, exported to th2 then compared to original th2.
The file contained 7 scraps, 4 xvi files and 1 scanned image.
It is more complicated than is typical for me - usually I only load 1 xvi or scanned image. Have attached both versions of the file.

A few things apparent:

3-HawkesPlan-exported from WTherion.th2.txt
3-HawkesPlan-created with XTherion.th2.txt

@daem-on
Copy link
Owner Author

daem-on commented Nov 30, 2022

@CaverBruce Thanks! Seems like the fixes I implemented were not at all enough, but these issues should be fixable. Like I said, I don't have a lot of time right now, maybe next week I'll be able to work on this. Thank you again for the testing and feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants