Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elements find #14

Open
Shemesh opened this issue Sep 2, 2022 · 4 comments
Open

elements find #14

Shemesh opened this issue Sep 2, 2022 · 4 comments

Comments

@Shemesh
Copy link

Shemesh commented Sep 2, 2022

hi,
is there a way to search by text?
for example - i want to find a scrap\station\etc by its name.

wish: ctrlF open a search box, type a text will show the number of hits found, button find next\prev will select relevant item in the drawing.

@daem-on
Copy link
Owner

daem-on commented Sep 2, 2022

This is good idea, and it's actually pretty easy to implement. However wtherion doesn't store the items as text, so what do you think specifically it should search through?

All items have IDs, stations also have names, and labels have text. Is there anything else?

We could also search through every property of every object but I think that would be unnecessary and slow.

@Shemesh Shemesh changed the title menu ux elements find Sep 2, 2022
@daem-on
Copy link
Owner

daem-on commented Sep 2, 2022

Take a look at 60e2fbb

@Shemesh
Copy link
Author

Shemesh commented Sep 2, 2022

looking good!
plz deploy it to the beta site, so it can be tested

@daem-on
Copy link
Owner

daem-on commented Sep 2, 2022

It's a CI, it deploys automatically.
You can find the deployment for each commit directly on netlify as well:
https://app.netlify.com/sites/roaring-gelato-4ea2f4/deploys/63122bd691754b0008687781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants