Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing imports in Refactoring assets to use resources in Dagster Essentials #22765

Closed
kornerc opened this issue Jun 28, 2024 · 1 comment · Fixed by #22774
Closed

Missing imports in Refactoring assets to use resources in Dagster Essentials #22765

kornerc opened this issue Jun 28, 2024 · 1 comment · Fixed by #22774
Labels
area: dagster-university Related to Dagster University

Comments

@kornerc
Copy link

kornerc commented Jun 28, 2024

What's the issue or suggestion?

In the lesson Practice: Refactoring assets to use resources of Dagster Essentials the suggested imports are not complete.

It is stated to update the imports in assets/metrics.py to the following:

import requests
from dagster_duckdb import DuckDBResource
from . import constants
from dagster import asset

However, the import of requests is not needed and the import of geopandas and other libraries is missing.

It should instead look similar to that:

from datetime import datetime, timedelta

from dagster import asset
from dagster_duckdb import DuckDBResource
import geopandas as gpd
import pandas as pd

# import plotly.express as px
# import plotly.io as pio

from . import constants

(the commented imports are needed for the asset manhattan_map)

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@kornerc kornerc added the area: docs Related to documentation in general label Jun 28, 2024
@garethbrickman garethbrickman added area: dagster-university Related to Dagster University and removed area: docs Related to documentation in general labels Jun 28, 2024
@cmpadden
Copy link
Contributor

@kornerc thank you for your attention to detail, I've opened this pull request to fix the imports as you suggested: #22774.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dagster-university Related to Dagster University
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants