Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Tone Color Scheme #152

Closed
ShahriarKh opened this issue Dec 24, 2023 · 2 comments
Closed

Two Tone Color Scheme #152

ShahriarKh opened this issue Dec 24, 2023 · 2 comments
Assignees
Labels
Feature Request Enhancement and/or Feature suggestion

Comments

@ShahriarKh
Copy link
Contributor

Currently, we have:
✅ Minimal
✅ Border
✅ Two Tone & Border

Another one can be added:
✳ Two Tone

P.S. I tried looking at the source code to see if I can create it myself, but couldn't find out how color schemes are handled.

@ShahriarKh ShahriarKh added the Feature Request Enhancement and/or Feature suggestion label Dec 24, 2023
@damiankorcz
Copy link
Owner

Hi @ShahriarKh,
I've considered adding it as a scheme when I added this option but in my opinion it looks quite bad. Looks unfinished in a way. Hence why it is missing. I don't intend on adding it. Also the current implementation of the other options is very minimal and elegant. I don't think this would be worth adding more lines of code just to make it better.

&.pt-color-scheme-style-border-dt {
--background-secondary: var(--background-secondary-alt);
--background-secondary-blur: var(--background-secondary-alt);
}
&.pt-color-scheme-style-minimal-dt {
--background-secondary: var(--background-secondary-alt);
--background-secondary-blur: var(--background-secondary-alt);
--window-border: 1px solid transparent;
}

image

image

@ShahriarKh
Copy link
Contributor Author

I see. I thought it will look good, but your screenshots clearly show that some parts require borders to look good. Thank you for your explanation 🫱🏼‍🫲🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement and/or Feature suggestion
Projects
None yet
Development

No branches or pull requests

2 participants