Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perfsprint linter errors #1374

Open
mukundansundar opened this issue Jan 16, 2024 · 2 comments
Open

Fix perfsprint linter errors #1374

mukundansundar opened this issue Jan 16, 2024 · 2 comments
Labels
good first issue Good for newcomers kind/proposal A new proposal to be considered
Milestone
v1.14

Comments

@mukundansundar
Copy link
Collaborator

Describe the proposal

For now //nolint: perfsprint has been added in some files in CLI.

Make changes in CLI to convert the fmt.Sprintf("%d)...) into strconv.Itoa and handle associated errors as well.

Release Note

RELEASE NOTE:
@mukundansundar mukundansundar added good first issue Good for newcomers kind/proposal A new proposal to be considered labels Jan 16, 2024
@mukundansundar mukundansundar added this to the v1.14 milestone Jan 16, 2024
@mukundansundar mukundansundar mentioned this issue Jan 16, 2024
Merged
3 tasks
@sp6370
Copy link

sp6370 commented Jan 16, 2024

@mukundansundar I would like to pick this up.

@sp6370
Copy link

sp6370 commented Jan 16, 2024

/assign

@sp6370 sp6370 removed their assignment Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/proposal A new proposal to be considered
Projects
None yet
Milestone
v1.14
Development

No branches or pull requests
2 participants
@sp6370 @mukundansundar