0x02 Attribute is possibly unsigned. Made all Signed Ints are now Unsigned. #44
Conversation
Preliminary testing has shown for this to connect and operate like normal. More testing is needed to make it gold. * Log -1 is now 0, I don't know if that impacts.
| @@ -2,7 +2,7 @@ | |||
| { | |||
| public class FriendRequestModel | |||
| { | |||
| public int Id { get; set; } | |||
| public uint Id { get; set; } | |||
There was a problem hiding this comment.
Let's keep these as int since it interacts with the database. We may need to add casting in places between our database and the protocol though.
| @@ -5,10 +5,10 @@ namespace PFire.Infrastructure.Entities | |||
| { | |||
| public class Friend : Entity | |||
| { | |||
| public int MeId { get; set; } | |||
| public uint MeId { get; set; } | |||
There was a problem hiding this comment.
I actually don't think EF supports unsigned ints. Let's try to keep all the interacts with the database to continue to use int.
There's no realistic concern we'll max out the size anyway
There was a problem hiding this comment.
Oh definitely, I just covered every base in my changes. I will make a new change in a bit.
| @@ -0,0 +1,22 @@ | |||
| using System; | |||
There was a problem hiding this comment.
If you can please also delete the Int32Attribute class in this PR too
| @@ -16,7 +16,8 @@ public class XFireAttributeFactory | |||
| private XFireAttributeFactory() | |||
| { | |||
| Add(new StringAttribute()); | |||
| Add(new Int32Attribute()); | |||
| //Add(new Int32Attribute()); | |||
There was a problem hiding this comment.
| //Add(new Int32Attribute()); |
Let's just delete this
|
As mentioned in Discord, I'll help test this 👍
No impact -- all good. |
I suspect that 0x02 int32 is unsigned.
Reasons to believe:
Reasons to reject:
pFire:
Preliminary testing has shown for this to connect and operate like normal. More testing is needed to make it gold.
Note: