Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better output for confrontation objects #129

Open
markvanderloo opened this issue Feb 1, 2021 · 3 comments
Open

better output for confrontation objects #129

markvanderloo opened this issue Feb 1, 2021 · 3 comments

Comments

@markvanderloo
Copy link
Member

More user-friendly print method. e.g. also showing the number of missings.

@markvanderloo
Copy link
Member Author

markvanderloo commented Feb 11, 2021

New output; comments welcome.

> check_that(SBS2000, turnover >= 0, other.rev >= 0, foo >= 1 )
Object of class 'validation'
Call:
    check_that(SBS2000, turnover >= 0, other.rev >= 0, foo >= 1)

Rules confronted: 3
   With fails   : 1
   With missings: 2
   Threw warning: 0
   Threw error  : 1

markvanderloo added a commit that referenced this issue Feb 11, 2021
@matthiasgomolka
Copy link

Showing the number of rules with missings is really helpful!

@edwindj
Copy link
Member

edwindj commented Feb 15, 2021

This is surely an improvement!

I opt for an extra statement whenever the number of missings is > 0.
Something along the lines:

Note: in some cases when rules interact, missings may indicate an invalidation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants