Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yco command has a huge rampup-time #32

Closed
davelosert opened this issue Dec 28, 2020 · 2 comments · Fixed by #40
Closed

yco command has a huge rampup-time #32

davelosert opened this issue Dec 28, 2020 · 2 comments · Fixed by #40
Labels
bug Something isn't working

Comments

@davelosert
Copy link
Owner

I realized that sometimes, starting up yco takes a lot of time ( 3 - 4 seconds ). This is not so bad if used in the CLI, but when using e.g. using apply-layout with a hotkey-combination, the user could get the impressions it's not working.

So we should investigate and fix this.
@davelosert davelosert added the bug Something isn't working label Dec 28, 2020
@davelosert
Copy link
Owner Author

Seems like this is an issue with esm: standard-things/esm#844

@davelosert davelosert mentioned this issue Dec 30, 2020
Merged
@davelosert
Copy link
Owner Author

I removed esm in #40 entirely falling back to simple NodeJS require-Statements for now.
Seemed to be the easiest and fastest solution.

We might switch back to esm when switching to Typescript #39 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/remove esm for performance davelosert/yco
1 participant
@davelosert