Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading comment on the "hashToPoint()" function #450

Open
kubasiemion opened this issue Feb 22, 2021 · 1 comment
Open

Misleading comment on the "hashToPoint()" function #450

kubasiemion opened this issue Feb 22, 2021 · 1 comment

Comments

@kubasiemion
Copy link

File kyber/pairing/bn256/point.go /, lines 224-225
A simple quid-pro-quo, but we should have mercy on the people trying to follow the algorithms:
// hashes a byte slice into two points on a curve represented by big.Int
// ideally we want to do this using gfP, but gfP doesn't have a ModSqrt function
func hashToPoint(m []byte) (*big.Int, *big.Int) {...}

Should be: "hashes into a point represented by two big.Int's"

@kubasiemion kubasiemion changed the title Misleading comment on the "hashToPoint()" funstion Misleading comment on the "hashToPoint()" function Feb 22, 2021
@ineiti
Copy link
Member

ineiti commented Feb 23, 2021

Thanks for the comment. Github makes it now really easy to propose changes to the files. So please feel free to open a PR against bn256/point.go.

@K1li4nL K1li4nL linked a pull request Apr 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants