Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gtf files should allow "." in phase column (parse.py) #19

Open
benbfly opened this issue Nov 1, 2020 · 3 comments
Open

Gtf files should allow "." in phase column (parse.py) #19

benbfly opened this issue Nov 1, 2020 · 3 comments

Comments

@benbfly
Copy link

benbfly commented Nov 1, 2020

Column 7 of GTF files are only allowed values "0", "1", or "2". But they often have "." for non-coding features. This is in the UCSC spec:
https://genome.ucsc.edu/FAQ/FAQformat.html#format3

@dpryan79
Copy link
Collaborator

dpryan79 commented Nov 1, 2020

Do you have an example of a GTF file that's getting parse incorrectly? The phase is ignored by deeptools_intervals.

@benbfly
Copy link
Author

benbfly commented Nov 2, 2020

In the end actually I think I had another problem with my GTF. I opened the issue because of the function description for seemsLikeGTF, which seemed to say that it could only be 0,1, or 2. But when I look down at the code, i see it actually takes '.' as well. I would recommend changing the function description comment just to avoid confusion:


Thanks!

@dpryan79
Copy link
Collaborator

dpryan79 commented Nov 2, 2020

@benbfly That's just a comment, the code checks for .:

if cols[7] != '.':
int(cols[7]) in [0, 1, 2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants