You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinks and streamlines the DNS-checking code to use 'execnet' which allows to execute python functions remotely.
DNS-checking is much faster as the ssh-connection is re-used, and there are much fewer roundtrips.
Instead of parsing the output of the "ip" command this PR uses a standard python "socket" pattern to determine IPV4 and IPV6 addresses. This is likely less dependent on the target enviroment, so could also work better with non-debian systems.
DNS checking now gives progress indicators (use -v|--verbose to see commands executed remotely)
Instead of parsing the output of the "ip" command this PR uses a standard python "socket" pattern to determine IPV4 and IPV6 addresses. This is likely less dependent on the target enviroment, so could also work better with non-debian systems.
Can we remove checking PTR records completely? See #336
Then there is no need to determine IP address which is not reliable anyway even with the new method: the host may not know its external IP address, this address may change in the future etc.
Can we remove checking PTR records completely? See #336 Then there is no need to determine IP address which is not reliable anyway even with the new method: the host may not know its external IP address, this address may change in the future etc.
we could probably remove the ip-address detection but
it's useful to at least check that the IP addresses A/AAAA records have reverse PTR records.
I'd suggest to do this in a separate PR though.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shrinks and streamlines the DNS-checking code to use 'execnet' which allows to execute python functions remotely.
DNS-checking is much faster as the ssh-connection is re-used, and there are much fewer roundtrips.
Instead of parsing the output of the "ip" command this PR uses a standard python "socket" pattern to determine IPV4 and IPV6 addresses. This is likely less dependent on the target enviroment, so could also work better with non-debian systems.
DNS checking now gives progress indicators (use -v|--verbose to see commands executed remotely)