vi-35 ToU check agreement changed

app/sidekiq/terms_of_use/sign_up_service_updater_job.rb

@@ -33,7 +33,7 @@ def perform(user_account_uuid, version)
       @user_account_uuid = user_account_uuid
       @version = version
 
-      return unless sec_id?
+      return if !sec_id? || agreement_unchanged?
 
       log_updated_icn
       terms_of_use_agreement.accepted? ? accept : decline
@@ -48,12 +48,40 @@ def log_updated_icn
       end
     end
 
+    def client
+      @client ||= MAP::SignUp::Service.new
+    end
+
+    def status
+      @status ||= client.status(icn: mpi_profile.icn)
+    end
+
+    def declined?
+      status[:opt_out] == true
+    end
+
+    def accepted?
+      status[:agreement_signed] == true
+    end
+
+    def agreement_unchanged?
+      return false unless terms_of_use_agreement
+
+      unchanged = (terms_of_use_agreement.declined? == declined?) && (terms_of_use_agreement.accepted? == accepted?)
+
+      if unchanged == true
+        Rails.logger.info("#{LOG_TITLE} Agreement not changed",
+                          { icn: user_account.icn })
+      end
+      unchanged
+    end
+
     def accept
-      MAP::SignUp::Service.new.agreements_accept(icn: mpi_profile.icn, signature_name:, version:)
+      client.agreements_accept(icn: mpi_profile.icn, signature_name:, version:)
     end
 
     def decline
-      MAP::SignUp::Service.new.agreements_decline(icn: mpi_profile.icn)
+      client.agreements_decline(icn: mpi_profile.icn)
     end
 
     def sec_id?

spec/sidekiq/terms_of_use/sign_up_service_updater_job_spec.rb

@@ -184,6 +184,63 @@
       end
     end
 
+    context 'when agreement is changed by ToU acceptance' do
+      let(:response) { 'accepted' }
+      let(:status) { { opt_out: true, agreement_signed: false } }
+
+      before do
+        allow(service_instance).to receive(:agreements_accept)
+        allow(service_instance).to receive(:status).and_return(status)
+      end
+
+      it 'agreement_unchanged returns false' do
+        job.perform(user_account_uuid, version)
+
+        expect(MAP::SignUp::Service).to have_received(:new)
+        expect(service_instance).to have_received(:agreements_accept).with(icn: user_account.icn,
+                                                                           signature_name: common_name,
+                                                                           version:)
+      end
+    end
+
+    context 'when agreement is changed by ToU being declined' do
+      let(:response) { 'declined' }
+      let(:status) { { opt_out: false, agreement_signed: true } }
+
+      before do
+        allow(service_instance).to receive(:agreements_decline)
+        allow(service_instance).to receive(:status).and_return(status)
+      end
+
+      it 'agreement_unchanged returns false' do
+        job.perform(user_account_uuid, version)
+
+        expect(MAP::SignUp::Service).to have_received(:new)
+        expect(service_instance).to have_received(:agreements_accept).with(icn: user_account.icn,
+                                                                           signature_name: common_name,
+                                                                           version:)
+      end
+    end
+
+    context 'when agreement is unchanged' do
+      let(:expected_log) do
+        '[TermsOfUse][SignUpServiceUpdaterJob] Agreement not changed'
+      end
+      let(:status) { { opt_out: false, agreement_signed: true } }
+
+      before do
+        allow(Rails.logger).to receive(:info)
+        allow(service_instance).to receive(:status).and_return(status)
+      end
+
+      it 'logs that the agreement is not changed' do
+        job.perform(user_account_uuid, version)
+
+        expect(MAP::SignUp::Service).to have_received(:new)
+        expect(Rails.logger).to have_received(:info).with(expected_log, icn:)
+      end
+    end
+
     context 'when sec_id is not present' do
       let(:sec_id) { nil }
       let(:expected_log) do