Api 40300 526 bd upload refactor

modules/claims_api/app/services/claims_api/disability_compensation/disability_document_service.rb

@@ -0,0 +1,79 @@
+# frozen_string_literal: true
+
+module ClaimsApi
+  module DisabilityCompensation
+    class DisabilityDocumentService < ServiceBase
+      LOG_TAG = '526_v2_Disability_Document_service'
+
+      def create_upload(claim:, pdf_path:, doc_type: 'L122', action: 'post', original_filename: nil)
+        unless File.exist? pdf_path
+          ClaimsApi::Logger.log('benefits_documents', detail: "Error creating upload doc: #{file_path} doesn't exist,
+                                                      claim_id: #{claim.id}")
+          raise Errno::ENOENT, pdf_path
+        end
+
+        body = generate_upload_body(claim:, doc_type:, pdf_path:, action:, original_filename:)
+        ClaimsApi::BD.new.upload_document(claim_id: claim.id, doc_type:, body:)
+      end
+
+      private
+
+      ##
+      # Generate form body to upload a document
+      #
+      # @return {parameters, file}
+      def generate_upload_body(claim:, doc_type:, pdf_path:, action:, original_filename: nil)
+        payload = {}
+        auth_headers = claim.auth_headers
+        veteran_name = compact_veteran_name(auth_headers['va_eauth_firstName'], auth_headers['va_eauth_lastName'])
+        birls_file_num = auth_headers['va_eauth_birlsfilenumber']
+        claim_id = claim.evss_id
+        file_name = generate_file_name(doc_type:, veteran_name:, claim_id:, original_filename:, action:)
+        tracked_item_ids = claim.tracked_items&.map(&:to_i) if claim&.has_attribute?(:tracked_items)
+        data = build_body(doc_type:, file_name:, claim_id:,
+                          file_number: birls_file_num, tracked_item_ids:)
+
+        fn = Tempfile.new('params')
+        File.write(fn, data.to_json)
+        payload[:parameters] = Faraday::UploadIO.new(fn, 'application/json')
+        payload[:file] = Faraday::UploadIO.new(pdf_path.to_s, 'application/pdf')
+        payload
+      end
+
+      def compact_veteran_name(first_name, last_name)
+        [first_name, last_name].compact_blank.join('_')
+      end
+
+      def generate_file_name(doc_type:, veteran_name:, claim_id:, original_filename:, action:)
+        if action == 'post' && doc_type == 'L122'
+          "#{[veteran_name, claim_id, '526EZ'].compact_blank.join('_')}.pdf"
+        else
+          filename = get_original_supporting_doc_file_name(original_filename)
+          "#{[veteran_name, claim_id, filename].compact_blank.join('_')}.pdf"
+        end
+      end
+
+      ##
+      # DisabilityCompensationDocuments method create_unique_filename adds a random 11 digit
+      # hex string to the original filename, so we remove that to yield the user-submitted
+      # filename to use as part of the filename uploaded to the BD service.
+      def get_original_supporting_doc_file_name(original_filename)
+        file_extension = File.extname(original_filename)
+        base_filename = File.basename(original_filename, file_extension)
+        base_filename[0...-12]
+      end
+
+      def build_body(options = {})
+        data = {
+          systemName: 'VA.gov',
+          docType: options[:doc_type],
+          fileName: options[:file_name],
+          trackedItemIds: options[:tracked_item_ids].presence || []
+        }
+        data[:claimId] = options[:claim_id] unless options[:claim_id].nil?
+        data[:fileNumber] = options[:file_number] unless options[:file_number].nil?
+        { data: }
+      end
+    end
+  end
+end

modules/claims_api/app/sidekiq/claims_api/claim_uploader.rb

@@ -47,7 +47,11 @@ def bd_upload_body(auto_claim:, file_body:, doc_type:, original_filename:)
     end
 
     def claim_bd_upload_document(claim, doc_type, pdf_path, original_filename) # rubocop:disable Metrics/MethodLength
-      ClaimsApi::BD.new.upload(claim:, doc_type:, pdf_path:, original_filename:)
+      if Flipper.enabled? :claims_api_bd_refactor
+        DisabilityCompensation::DisabilityDocumentService.new.create_upload(claim:, pdf_path:, original_filename:)
+      else
+        ClaimsApi::BD.new.upload(claim:, doc_type:, pdf_path:, original_filename:)
+      end
     # Temporary errors (returning HTML, connection timeout), retry call
     rescue Faraday::ParsingError, Faraday::TimeoutError => e
       message = get_error_message(e)

modules/claims_api/app/sidekiq/claims_api/v2/disability_compensation_benefits_documents_uploader.rb

@@ -62,7 +62,11 @@ def bd_upload_body(auto_claim:, file_body:)
       end
 
       def claim_bd_upload_document(claim, pdf_path)
-        ClaimsApi::BD.new.upload(claim:, pdf_path:)
+        if Flipper.enabled? :claims_api_bd_refactor
+          DisabilityCompensation::DisabilityDocumentService.new.create_upload(claim:, pdf_path:)
+        else
+          ClaimsApi::BD.new.upload(claim:, pdf_path:)
+        end
       end
     end
   end

modules/claims_api/lib/bd/bd.rb

@@ -67,6 +67,27 @@ def upload(claim:, pdf_path:, doc_type: 'L122', action: 'post', original_filenam
       raise e
     end
 
+    def upload_document(claim_id:, doc_type:, body:)
+      @multipart = true
+      res = client.post('documents', body)&.body
+
+      raise ::Common::Exceptions::GatewayTimeout.new(detail: 'Upstream service error.') unless res.is_a?(Hash)
+
+      res = res.deep_symbolize_keys
+      request_id = res.dig(:data, :requestId)
+      ClaimsApi::Logger.log('benefits_documents',
+                            detail: "Successfully uploaded #{doc_type} doc to BD,
+                                                    #{doc_type}_id: #{claim_id}",
+                            request_id:)
+      res
+    rescue => e
+      ClaimsApi::Logger.log('benefits_documents',
+                            detail: "/upload failure for
+                                                    #{doc_type}_id: #{claim_id},
+                                                    #{e.message}")
+      raise e
+    end
+
     private
 
     def doc_type_to_plain_language(doc_type)
@@ -104,7 +125,8 @@ def generate_upload_body(claim:, doc_type:, pdf_path:, action:, original_filenam
                              pctpnt_vet_id: nil)
       payload = {}
       auth_headers = claim.auth_headers
-      veteran_name = compact_veteran_name(auth_headers['va_eauth_firstName'], auth_headers['va_eauth_lastName'])
+      veteran_name = compact_veteran_name(auth_headers['va_eauth_firstName'],
+                                          auth_headers['va_eauth_lastName'])
       birls_file_num = determine_birls_file_number(doc_type, auth_headers)
       claim_id = get_claim_id(doc_type, claim)
       file_name = generate_file_name(doc_type:, veteran_name:, claim_id:, original_filename:, action:)