From ff90bffb4f68dac52c3f92eb27a64cd7428dea9d Mon Sep 17 00:00:00 2001 From: Jennica Stiehl <25069483+stiehlrod@users.noreply.github.com> Date: Tue, 8 Oct 2024 12:03:32 -0600 Subject: [PATCH] Adds maximum request example. Updates dev/swagger & prod/swagger. --- .../swagger/claims_api/v2/dev/swagger.json | 29 +-- .../claims_api/v2/production/swagger.json | 29 +-- .../valid_526_maximum.json | 216 ++++++++++++++++++ .../requests/v2/veterans/rswag_526_spec.rb | 3 +- 4 files changed, 241 insertions(+), 36 deletions(-) create mode 100644 modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/valid_526_maximum.json diff --git a/modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json b/modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json index 38cef54fca6..de664ec92bb 100644 --- a/modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json +++ b/modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json @@ -4966,8 +4966,7 @@ "serviceBranch": "Public Health Service", "serviceComponent": "Active", "activeDutyBeginDate": "2008-11-14", - "activeDutyEndDate": "2023-10-30", - "separationLocationCode": "98282" + "activeDutyEndDate": "2023-10-30" } ], "servedInActiveCombatSince911": "NO", @@ -4985,10 +4984,6 @@ }, "receivingInactiveDutyTrainingPay": "YES" }, - "federalActivation": { - "activationDate": "2023-10-01", - "anticipatedSeparationDate": "2024-10-31" - }, "confinements": [ { "approximateBeginDate": "2018-06-04", @@ -5077,7 +5072,7 @@ "202 without a transactionId": { "value": { "data": { - "id": "842d260d-1ffe-4a29-b5ed-117b38bd3ad5", + "id": "4a388f05-e149-4a38-9cc2-e3ece862e217", "type": "forms/526", "attributes": { "claimId": "600442191", @@ -5262,7 +5257,7 @@ }, "federalActivation": { "activationDate": "2023-10-01", - "anticipatedSeparationDate": "2024-10-05" + "anticipatedSeparationDate": "2024-10-10" }, "confinements": [ { @@ -5308,7 +5303,7 @@ "202 with a transactionId": { "value": { "data": { - "id": "9580281a-95bc-4a99-8171-10b987a1b887", + "id": "bcc4f0d1-71c3-4b1d-9fe7-b9c94c51ebbf", "type": "forms/526", "attributes": { "claimId": "600442191", @@ -10526,7 +10521,7 @@ "application/json": { "example": { "data": { - "id": "854bc725-fa9e-438e-bc7f-9a484160cf30", + "id": "9a083804-718e-489b-b734-b7829545ac26", "type": "forms/526", "attributes": { "claimProcessType": "STANDARD_CLAIM_PROCESS", @@ -14274,8 +14269,8 @@ "id": "1", "type": "intent_to_file", "attributes": { - "creationDate": "2024-10-03", - "expirationDate": "2025-10-03", + "creationDate": "2024-10-08", + "expirationDate": "2025-10-08", "type": "compensation", "status": "active" } @@ -15072,7 +15067,7 @@ "status": "422", "detail": "Could not retrieve Power of Attorney due to multiple representatives with code: A1Q", "source": { - "pointer": "/modules/claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/base_controller.rb:134:in `representative'" + "pointer": "/modules/claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/base_controller.rb:135:in `representative'" } } ] @@ -15171,7 +15166,7 @@ "application/json": { "example": { "data": { - "id": "10295307-73bb-4825-95f5-02d6df41a4e1", + "id": "302072a0-ee9c-4936-a44b-3493a7043e4c", "type": "individual", "attributes": { "code": "067", @@ -15864,7 +15859,7 @@ "application/json": { "example": { "data": { - "id": "9abb338d-2390-472c-bb0a-8a1c7da2ba32", + "id": "730ef862-70a8-4618-b86a-de305ab97888", "type": "organization", "attributes": { "code": "083", @@ -17815,10 +17810,10 @@ "application/json": { "example": { "data": { - "id": "3b595df2-25af-4c3e-a48b-56478c80983d", + "id": "2415d8b3-ee24-475b-aa5f-41f020c71f98", "type": "claimsApiPowerOfAttorneys", "attributes": { - "dateRequestAccepted": "2024-10-03", + "dateRequestAccepted": "2024-10-08", "previousPoa": null, "representative": { "serviceOrganization": { diff --git a/modules/claims_api/app/swagger/claims_api/v2/production/swagger.json b/modules/claims_api/app/swagger/claims_api/v2/production/swagger.json index 4fa378fe322..8e90b6ca158 100644 --- a/modules/claims_api/app/swagger/claims_api/v2/production/swagger.json +++ b/modules/claims_api/app/swagger/claims_api/v2/production/swagger.json @@ -3579,8 +3579,7 @@ "serviceBranch": "Public Health Service", "serviceComponent": "Active", "activeDutyBeginDate": "2008-11-14", - "activeDutyEndDate": "2023-10-30", - "separationLocationCode": "98282" + "activeDutyEndDate": "2023-10-30" } ], "servedInActiveCombatSince911": "NO", @@ -3598,10 +3597,6 @@ }, "receivingInactiveDutyTrainingPay": "YES" }, - "federalActivation": { - "activationDate": "2023-10-01", - "anticipatedSeparationDate": "2024-10-31" - }, "confinements": [ { "approximateBeginDate": "2018-06-04", @@ -3690,7 +3685,7 @@ "202 without a transactionId": { "value": { "data": { - "id": "53a89319-954b-4f30-96c8-c4b832d104a6", + "id": "d737a9d0-4d90-494b-a320-9daae2d126a4", "type": "forms/526", "attributes": { "claimId": "600442191", @@ -3875,7 +3870,7 @@ }, "federalActivation": { "activationDate": "2023-10-01", - "anticipatedSeparationDate": "2024-10-05" + "anticipatedSeparationDate": "2024-10-10" }, "confinements": [ { @@ -3921,7 +3916,7 @@ "202 with a transactionId": { "value": { "data": { - "id": "a71d411d-5626-416f-9c01-366b3c2719f2", + "id": "0ceb7051-577e-4435-af6b-a2c143cbcba0", "type": "forms/526", "attributes": { "claimId": "600442191", @@ -9139,7 +9134,7 @@ "application/json": { "example": { "data": { - "id": "de754a68-be13-4767-a299-dc7587bf23ab", + "id": "0c87e56d-c6be-4629-84ca-a72b7442c5f2", "type": "forms/526", "attributes": { "claimProcessType": "STANDARD_CLAIM_PROCESS", @@ -12887,8 +12882,8 @@ "id": "1", "type": "intent_to_file", "attributes": { - "creationDate": "2024-10-03", - "expirationDate": "2025-10-03", + "creationDate": "2024-10-08", + "expirationDate": "2025-10-08", "type": "compensation", "status": "active" } @@ -13685,7 +13680,7 @@ "status": "422", "detail": "Could not retrieve Power of Attorney due to multiple representatives with code: A1Q", "source": { - "pointer": "/modules/claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/base_controller.rb:134:in `representative'" + "pointer": "/modules/claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/base_controller.rb:135:in `representative'" } } ] @@ -13784,7 +13779,7 @@ "application/json": { "example": { "data": { - "id": "fc09bcf9-4334-40f9-83cd-e105223c5e77", + "id": "da0b0922-6b53-4351-a6b2-b27c78061342", "type": "individual", "attributes": { "code": "067", @@ -14477,7 +14472,7 @@ "application/json": { "example": { "data": { - "id": "da954be2-3a04-4889-adec-7ea428c56e2b", + "id": "064d4345-e018-415b-a667-618996955fa6", "type": "organization", "attributes": { "code": "083", @@ -16428,10 +16423,10 @@ "application/json": { "example": { "data": { - "id": "6ccb865e-ef3f-4999-ace0-963a62194085", + "id": "6a732110-d175-4b3a-a941-3b04201ecb46", "type": "claimsApiPowerOfAttorneys", "attributes": { - "dateRequestAccepted": "2024-10-03", + "dateRequestAccepted": "2024-10-08", "previousPoa": null, "representative": { "serviceOrganization": { diff --git a/modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/valid_526_maximum.json b/modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/valid_526_maximum.json new file mode 100644 index 00000000000..f3509c71255 --- /dev/null +++ b/modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/valid_526_maximum.json @@ -0,0 +1,216 @@ +{ + "data": { + "type": "form/526", + "attributes": { + "claimProcessType": "STANDARD_CLAIM_PROCESS", + "claimNotes": "Some things that are important to know, and are not included in any other place.", + "veteranIdentification": { + "serviceNumber": "123456789", + "veteranNumber": { + "telephone": "5555555555", + "internationalTelephone": "+44 20 1234 5678" + }, + "mailingAddress": { + "addressLine1": "1234 Couch Street", + "addressLine2": "Unit 4", + "addressLine3": "Room 1", + "city": "Schenectady", + "state": "NY", + "country": "USA", + "zipFirstFive": "12345", + "zipLastFour": "1234" + }, + "emailAddress": { + "email": "valid@somedomain.com", + "agreeToEmailRelatedToClaim": true + }, + "currentVaEmployee": false + }, + "changeOfAddress": { + "typeOfAddressChange": "TEMPORARY", + "addressLine1": "10 Peach St", + "addressLine2": "Unit 4", + "addressLine3": "Room 1", + "city": "Schenectady", + "state": "NY", + "country": "USA", + "zipFirstFive": "12345", + "zipLastFour": "9897", + "dates": { + "beginDate": "2023-06-04", + "endDate": "2023-12-04" + } + }, + "homeless": { + "isCurrentlyHomeless": true, + "currentlyHomeless": { + "homelessSituationOptions": "FLEEING_CURRENT_RESIDENCE", + "otherDescription": "ABCDEFGHIJKLM" + }, + "isAtRiskOfBecomingHomeless": false, + "pointOfContact": "john stewart", + "pointOfContactNumber": { + "telephone": "5555555555", + "internationalTelephone": "+44 20 1234 5678" + } + }, + "toxicExposure": { + "gulfWarHazardService": { + "servedInGulfWarHazardLocations": "YES", + "serviceDates": { + "beginDate": "2018-07", + "endDate": "2018-08" + } + }, + "herbicideHazardService": { + "servedInHerbicideHazardLocations": "YES", + "otherLocationsServed": "ABCDEFGHIJKLM", + "serviceDates": { + "beginDate": "2018-07", + "endDate": "2018-08" + } + }, + "additionalHazardExposures": { + "additionalExposures": ["ASBESTOS", "SHIPBOARD_HAZARD_AND_DEFENSE"], + "specifyOtherExposures": "Other exposure details", + "exposureDates": { + "beginDate": "2018-07", + "endDate": "2018-08" + } + }, + "multipleExposures": [ + { + "hazardExposedTo": "RADIATION", + "exposureLocation": "Guam", + "exposureDates": { + "beginDate": "2012-12", + "endDate": "2013-07" + } + } + ] + }, + "disabilities": [ + { + "name": "Traumatic Brain Injury", + "exposureOrEventOrInjury": "EXPOSURE", + "serviceRelevance": "ABCDEFG", + "approximateDate": "2018-03-11", + "disabilityActionType": "NEW", + "classificationCode": "9014", + "ratedDisabilityId": "ABCDEFGHIJKLMNOPQRSTUVWX", + "diagnosticCode": 9020, + "isRelatedToToxicExposure": true, + "secondaryDisabilities": [ + { + "name": "Post Traumatic Stress Disorder (PTSD) Combat - Mental Disorders", + "exposureOrEventOrInjury": "EXPOSURE", + "serviceRelevance": "ABCDEFGHIJKLMNOPQ", + "disabilityActionType": "SECONDARY", + "approximateDate": "2018-03-12", + "classificationCode": "9014" + } + ] + }, + { + "name": "Cancer - Musculoskeletal - Elbow", + "exposureOrEventOrInjury": "EXPOSURE", + "approximateDate": "2018-03-02", + "serviceRelevance": "ABCDEFG", + "disabilityActionType": "NEW", + "classificationCode": "9014", + "ratedDisabilityId": "ABCDEFGHIJKLMNOPQRSTUVWX", + "diagnosticCode": 249470, + "isRelatedToToxicExposure": true + }, + { + "name": "Cancer - Musculoskeletal - Knee", + "exposureOrEventOrInjury": "EXPOSURE", + "approximateDate": "2015", + "serviceRelevance": "ABCDEFG", + "disabilityActionType": "NEW", + "classificationCode": "9014", + "ratedDisabilityId": "ABCDEFGHIJKLMNOPQRSTUVWX", + "diagnosticCode": 249470, + "isRelatedToToxicExposure": true + } + ], + "treatments": [ + { + "beginDate": "2009-03", + "treatedDisabilityNames": [ + "Traumatic Brain Injury", + "Post Traumatic Stress Disorder (PTSD) Combat - Mental Disorders", + "Cancer - Musculoskeletal - Elbow" + ], + "center": { + "name": "Center One", + "city": "Decatur", + "state": "GA" + } + } + ], + "serviceInformation": { + "alternateNames": ["john jacob", "johnny smith"], + "servicePeriods": [ + { + "serviceBranch": "Public Health Service", + "serviceComponent": "Active", + "activeDutyBeginDate": "2008-11-14", + "activeDutyEndDate": "2023-10-30" + } + ], + "servedInActiveCombatSince911": "NO", + "reservesNationalGuardService": { + "component": "National Guard", + "obligationTermsOfService": { + "beginDate": "2019-06-04", + "endDate": "2020-06-04" + }, + "unitName": "National Guard Unit Name", + "unitAddress": "1243 pine court", + "unitPhone": { + "areaCode": "555", + "phoneNumber": "5555555" + }, + "receivingInactiveDutyTrainingPay": "YES" + }, + "confinements": [ + { + "approximateBeginDate": "2018-06-04", + "approximateEndDate": "2018-07-04" + }, + { + "approximateBeginDate": "2020-06", + "approximateEndDate": "2020-07" + } + ] + }, + "servicePay": { + "receivingMilitaryRetiredPay": "NO", + "futureMilitaryRetiredPay": "YES", + "futureMilitaryRetiredPayExplanation": "ABCDEFGHIJKLMNOPQRSTUVW", + "militaryRetiredPay": { + "branchOfService": "Army", + "monthlyAmount": 840 + }, + "retiredStatus": "PERMANENT_DISABILITY_RETIRED_LIST", + "favorMilitaryRetiredPay": false, + "receivedSeparationOrSeverancePay": "NO", + "separationSeverancePay": { + "datePaymentReceived": "2022-03-12", + "branchOfService": "Naval Academy", + "preTaxAmountReceived": 379 + }, + "favorTrainingPay": true + }, + "directDeposit": { + "noAccount": false, + "accountNumber": "ABCDEF", + "accountType": "CHECKING", + "financialInstitutionName": "Chase", + "routingNumber": "123123123" + }, + "claimantCertification": true + } + } +} \ No newline at end of file diff --git a/modules/claims_api/spec/requests/v2/veterans/rswag_526_spec.rb b/modules/claims_api/spec/requests/v2/veterans/rswag_526_spec.rb index 113aa06b460..d7c1fafb94a 100644 --- a/modules/claims_api/spec/requests/v2/veterans/rswag_526_spec.rb +++ b/modules/claims_api/spec/requests/v2/veterans/rswag_526_spec.rb @@ -84,8 +84,7 @@ def append_example_metadata(example, response) }, 'Maximum Attributes' => { value: JSON.parse(Rails.root.join('modules', 'claims_api', 'spec', 'fixtures', 'v2', 'veterans', - 'disability_compensation', 'form_526_json_api.json').read) - + 'disability_compensation', 'valid_526_maximum.json').read) } }