Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

30 instead of 30s in sshd-18 #148

Open
Tracked by #19
micheelengronne opened this issue Apr 16, 2020 · 5 comments
Open
Tracked by #19

30 instead of 30s in sshd-18 #148

micheelengronne opened this issue Apr 16, 2020 · 5 comments

Comments

@micheelengronne
Copy link
Member

Is your feature request related to a problem? Please describe.
I use https://github.com/dev-sec/cis-dil-benchmark as well as this profile. In the cis profile the check is '<60'. To put '30s' instead of '30' makes this check red.

Describe the solution you'd like
Use '30' instead of '30s'.

Describe alternatives you've considered
Disable this check and rely only on the one provided by the cis profile.

@chris-rock
Copy link
Member

we should probably implement the same approach as for cis dil https://github.com/dev-sec/cis-dil-benchmark/pull/77/files#diff-3706714fcee91eea31b371bd982f1284R233

@micheelengronne
Copy link
Member Author

yes, but the current one is more restrictive than the CIS one. Should we use the 60 of the CIS or the 30 of this one ?

@chris-rock
Copy link
Member

We have many cases where the CIS rules are not necessarily restrictive. I think we should make that optional, so that those baseline can be executed together. Therefore we should create an attribute and keep the default value at 30s for now. Would that help with your issue?

@micheelengronne
Copy link
Member Author

I think just by removing the s at the end of 30s both profiles are compatible. CIS just checks that the value is under 60 and it canno't compare the value with the final s as it is not an int. By removing that s, CIS can compare and as 30<60, both profiles are compatible.

@micheelengronne
Copy link
Member Author

#153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants