Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure AD roles claim #2108

Open
Fresa opened this issue May 5, 2021 · 4 comments
Open

Support Azure AD roles claim #2108

Fresa opened this issue May 5, 2021 · 4 comments

Comments

@Fresa
Copy link

Fresa commented May 5, 2021

App registrations in Azure AD support custom application roles that are emitted as a roles claim in the id_token.
https://docs.microsoft.com/en-us/azure/active-directory/develop/howto-add-app-roles-in-azure-ad-apps

Is your feature request related to a problem?

Roles is a nice alternative or complement to groups as explained in the linked document from Microsoft. It also doesn't need any permissions that require global admin consent, like Directory.Read.All.

Describe the solution you'd like to see

I guess this would require a new custom claim in dex as it's not a standard claim?

Describe alternatives you've considered

N/A

Additional context

I added a comment in #1182 as well as another rational for custom claims mapping.

@sagikazarmark
Copy link
Member

The linked issue is slightly different in my opinion. We have similar claim mapping solutions in other providers. groups is a distinguished claim in Dex, so we can add it to the connector configuration similarly.

@megakoresh
Copy link

This is also needed for any large organization because groups claim in Azure-returned JWT has a character limit, so if a person is member of too many, then they won't all fit to the token. The recommended solution to this is to use roles. Relevant doc

@PG2000
Copy link

PG2000 commented May 24, 2022

@sagikazarmark Do you know how we can proceed with this?

@cdenneen
Copy link

Still open issue. Application Roles would be very useful. Groups can become unwieldy quick so using roles would be more "lean" for doing RBAC mapping vs groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants