Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.2 on npm is the same as 1.0.1 #7

Open
terence1990 opened this issue Apr 29, 2024 · 1 comment
Open

Version 1.0.2 on npm is the same as 1.0.1 #7

terence1990 opened this issue Apr 29, 2024 · 1 comment

Comments

@terence1990
Copy link

terence1990 commented Apr 29, 2024

Looks like npm run build (or whatever you're using to compile) may not have been ran before npm publish for 1.0.2..

For example, the dist/index.cjs still shows on line 347

entries.gpsInfo = IFDHandler(subuffer, $0b53e5b7c7fe341c$var$tags.gps, gps);

rather than

entries.gpsInfo = this._decodeIDFEntries(buffer, $0b53e5b7c7fe341c$var$tags.gps, gps);

but line 271 is the src/marjers/exif.js in the bundle is as expected:

entries.gpsInfo = this._decodeIDFEntries(buffer, tags.gps, gps, true);

Result being i need to run npm i && npm run build in the node_modules/jay-peg after npm i to ensure the issue related to this change is resolved

@gabrielhamel
Copy link

@diegomura It seem there was a confusion when you've uploaded the package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants