Refactor: Consolidate setQueryParam

discretize · Sep 30, 2024 · bbc506f · bbc506f
1 parent 4aea486
commit bbc506f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/src/components/nav/NavBar.jsx b/src/components/nav/NavBar.jsx
@@ -33,7 +33,6 @@ import {
 import { changeGameMode, getExpertMode, getGameMode } from '../../state/slices/userSettings';
 import data from '../../utils/data';
 import { PROFESSIONS } from '../../utils/gw2-data';
-import { PARAMS, setQueryParm } from '../../utils/queryParam';
 import NavAccordion from './NavAccordion';
 import NavSettings from './NavSettings';
 import ReapplyTemplateDialog from './ReapplyTemplateDialog';
@@ -99,7 +98,6 @@ const Navbar = () => {
     // only cycles between raids and fractals
     const newGameMode = gamemode === 'raids' ? 'fractals' : 'raids';
 
-    setQueryParm({ key: PARAMS.GAMEMODE, value: newGameMode });
     dispatch(changeGameMode(newGameMode));
 
     const isFractalsNew = newGameMode === 'fractals';

diff --git a/src/components/nav/NavSettings.jsx b/src/components/nav/NavSettings.jsx
@@ -31,7 +31,6 @@ import {
   getExpertMode,
   getGameMode,
 } from '../../state/slices/userSettings';
-import { PARAMS, setQueryParm } from '../../utils/queryParam';
 import LanguageSelection from '../baseComponents/LanguageSelection';
 import Settings from '../baseComponents/Settings';
 import ReapplyTemplateDialog from './ReapplyTemplateDialog';
@@ -94,7 +93,6 @@ export default function NavSettings({
   };
   const changeGameModeHandler = (e) => {
     const newGameMode = e.target.value;
-    setQueryParm({ key: PARAMS.GAMEMODE, value: newGameMode });
     dispatch(changeGameMode(newGameMode));
 
     const isFractalsNew = newGameMode === 'fractals';

diff --git a/src/state/slices/userSettings.ts b/src/state/slices/userSettings.ts
@@ -53,6 +53,7 @@ export const userSettingsSlice = createSlice({
     },
     changeGameMode: (state, action: PayloadAction<GameMode>) => {
       state.gameMode = action.payload;
+      setQueryParm({ key: PARAMS.GAMEMODE, value: action.payload });
     },
   },