Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coupons page: sort by expires_at by default #116

Open
smirolo opened this issue Aug 2, 2019 · 0 comments
Open

coupons page: sort by expires_at by default #116

smirolo opened this issue Aug 2, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@smirolo
Copy link
Contributor

smirolo commented Aug 2, 2019

On page http://localhost:8000/billing/djaoapp/coupons/
Currently the default sort order is -created_at which is useless.
The default sort should be by expires_at (coupons with no expiration dates listed first) and alphabetically second when the expiration date for two coupons are the same.

To test, run the following command to create coupons:
python manage.py load_test_transactions

Then browse to http://localhost:8000/billing/djaoapp/coupons/
The coupons should be sorted by expiration date.

The templates involved is saas/billing/coupons.html

@smirolo smirolo added enhancement New feature or request good first issue Good for newcomers labels Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant