No rule to make target zlib/libz.a

[ypchan]

Dear Daniel，
I have some problems in installing dashing. I listed the errors below. Could you give me some suggessions?
Thanks.

make dashing

cd bonsai && make zlib/libz.a && cd ..
make[1]: Entering directory `/data/6190113/biosoft/dashing_git/bonsai'
make[1]: *** No rule to make target `zlib/libz.a'.  Stop.
make[1]: Leaving directory `/data/6190113/biosoft/dashing_git/bonsai'
make: *** [bonsai/zlib/libz.a] Error 2

and I checked the Makefile in bonsai, No target named `zlib/libz.a,
then I typed :

cd bonsai
make all

Another error occurred.

g++ -O3 -funroll-loops -pipe -fno-strict-aliasing -march=native -mpclmul   -fopenmp -fno-rtti -std=c++14 -Wall -Wextra -Wno-char-subscripts -Wpointer-arith -Wwrite-strings -Wdisabled-optimization -Wformat -Wcast-align -Wno-unused-function -Wno-unused-parameter -pedantic -DUSE_PDQSORT -Wunused-variable -Wno-attributes -Wno-cast-align -Wno-gnu-zero-variadic-macro-arguments -Wno-ignored-attributes -Wno-missing-braces -DBONSAI_VERSION=\"v0.2.4-39-ga168\" -DNDEBUG -Iclhash/include -I. -I.. -Ihll/libpopcnt -I.. -Iinclude -Icircularqueue -Izstd/zlibWrapper -Izstd/lib/common -Izstd/lib  -Ihll/vec -Ihll -Ihll/include -Ipdqsort -Iinclude/bonsai -Iinclude -Ihll/vec/blaze -L.  clhash.o klib/kthread.o -DNDEBUG bin/bonsai.cpp -o bin/bonsai -lz
In file included from hll/include/sketch/common.h:62,
                 from hll/include/sketch/hll.h:3,
                 from include/bonsai/./popcnt.h:13,
                 from include/bonsai/./util.h:30,
                 from include/bonsai/encoder.h:3,
                 from include/bonsai/feature_min.h:3,
                 from bin/bonsai.cpp:4:
hll/include/sketch/./exception.h: In static member function ‘static const char* sketch::exception::ZlibError::es(int)’:
hll/include/sketch/./exception.h:67:14: error: ‘z_const’ was not declared in this scope
             (z_const char *)"need dictionary",     /* Z_NEED_DICT       2  */
              ^~~~~~~
hll/include/sketch/./exception.h:67:21: error: expected ‘)’ before ‘char’
             (z_const char *)"need dictionary",     /* Z_NEED_DICT       2  */
             ~       ^~~~~
                     )
At global scope:
cc1plus: warning: unrecognized command line option ‘-Wno-gnu-zero-variadic-macro-arguments’
make: *** [bin/bonsai] Error 1

[dnbaker]

Hi ypchan,

Thanks for the issue! I'm surprised by the failure to compile; did you clone dashing recursively? (--recursive?)

I would expect git clone --recursive dashing && cd dashing && make dashing to work. Otherwise, git submodule update --init --recursive should fetch and check out commits as necessary.

z_const and Z_NEED_DICT should be set by zlib, so most likely that will be fixed with recompilation, but I've also updated the sketch library to not rely on definitions for them. The most recent version shouldn't have this issue.

Let me know if you have any further issues,

Daniel