Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] python 3.10 supports #66

Open
noraj opened this issue Nov 22, 2022 · 11 comments
Open

[Feature request] python 3.10 supports #66

noraj opened this issue Nov 22, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@noraj
Copy link
Contributor

noraj commented Nov 22, 2022

I have seen:

Would be nice to have python 3.10 support for server install.

@dolevf
Copy link
Owner

dolevf commented Nov 30, 2022

I can give this a look. In the past, if I recall correctly, some of the dependencies that DVGA uses do not yet support 3.10 themselves. I will check whether there has been any progress.

@dolevf dolevf added the enhancement New feature or request label Nov 30, 2022
@dolevf
Copy link
Owner

dolevf commented Dec 10, 2022

Yeah, so I looked into this and it appears the websockets/graphql subscription functionality is broken and not currently supported in 3.10. We will need to swap out flask-sockets library with something which is not a small lift. We may look into this in the future but at this point we will put this on ice.

@dolevf
Copy link
Owner

dolevf commented Dec 16, 2022

@noraj please see branch https://github.com/dolevf/Damn-Vulnerable-GraphQL-Application/tree/dvga-py3-10 where we have DVGA running on Python 3.10, and if possible, please give it a test run to see everything is working as expected, in particular:

  • WebSockets
  • GraphQL Subscriptions

@dolevf dolevf added help wanted Extra attention is needed and removed Future consideration labels Dec 16, 2022
@noraj
Copy link
Contributor Author

noraj commented Dec 19, 2022

Subscription request

With Python 3.10 from the dvga-py3-10

image

With Python 3.7 from the dockerhub image

image

So I don't have a working subscription request that I could test.

@dolevf
Copy link
Owner

dolevf commented Dec 20, 2022

you can use Altair Client, I believe GraphiQL doesn't support subscriptions

@noraj
Copy link
Contributor Author

noraj commented Dec 20, 2022

you can use Altair Client, I believe GraphiQL doesn't support subscriptions

I tried it with Insomnia too, that claims to support websockets Kong/insomnia#4477, cf. https://insomnia.rest/changelog#2022.6.0 and https://docs.insomnia.rest/insomnia/websockets. So I asked if it supports GraphQL subscriptions.

Well then, I'll try again with Altair.

@dolevf
Copy link
Owner

dolevf commented Dec 20, 2022

I'm going to look into the errors that you're observing. Another way you can explore this is:

  1. Load the UI
  2. Go to Public Pastes
  3. Create a paste with the mutation createPaste
  4. Observe that the Public Paste page (step 2) updated the page immediately without a refresh

@dolevf
Copy link
Owner

dolevf commented Dec 20, 2022

2022-12-20.13-34-18.mp4

@noraj
Copy link
Contributor Author

noraj commented Dec 29, 2022

Subscriptions seems to work well on my side.

@noraj
Copy link
Contributor Author

noraj commented Dec 29, 2022

While we are at it we may update it to Python 3.11.

@dolevf
Copy link
Owner

dolevf commented Jan 4, 2023

hmm, that will require some additional work, I'll try to find some time.

@dolevf dolevf self-assigned this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants