-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] python 3.10 supports #66
Comments
I can give this a look. In the past, if I recall correctly, some of the dependencies that DVGA uses do not yet support 3.10 themselves. I will check whether there has been any progress. |
Yeah, so I looked into this and it appears the websockets/graphql subscription functionality is broken and not currently supported in 3.10. We will need to swap out flask-sockets library with something which is not a small lift. We may look into this in the future but at this point we will put this on ice. |
@noraj please see branch https://github.com/dolevf/Damn-Vulnerable-GraphQL-Application/tree/dvga-py3-10 where we have DVGA running on Python 3.10, and if possible, please give it a test run to see everything is working as expected, in particular:
|
you can use Altair Client, I believe GraphiQL doesn't support subscriptions |
I tried it with Insomnia too, that claims to support websockets Kong/insomnia#4477, cf. https://insomnia.rest/changelog#2022.6.0 and https://docs.insomnia.rest/insomnia/websockets. So I asked if it supports GraphQL subscriptions. Well then, I'll try again with Altair. |
I'm going to look into the errors that you're observing. Another way you can explore this is:
|
2022-12-20.13-34-18.mp4 |
Subscriptions seems to work well on my side. |
While we are at it we may update it to Python 3.11. |
hmm, that will require some additional work, I'll try to find some time. |
I have seen:
Note: Python 3.10 is not supported yet!
Would be nice to have python 3.10 support for server install.
The text was updated successfully, but these errors were encountered: