Link to Billing #73
Link to Billing #73
Conversation
jan-krueger
force-pushed
the
feature-billing-link
branch
from
f5706b3
to
7f701a5
Compare
| } else if(bills.length > 1) { | ||
| for(let i = 0; i < bills.length; i++) { | ||
| if(bills[i]['name'].includes(name.toLowerCase())) { | ||
| return bills[i]; | ||
| } | ||
| } | ||
|
|
||
| let fuse = new Fuse(bills, {keys: ['name']}) | ||
| let results = fuse.search(name); | ||
|
|
||
| if(results.length > 0) { | ||
| return results[0]; | ||
| } | ||
| } |
There was a problem hiding this comment.
How big is the hangar you're testing with?
I know some people have a few thousand items in their hangar, and grey-marketeers also have considerable invoice history - just some things to consider. I haven't had a chance to do a full review yet, just doing a quick read over the code before bed :)
There was a problem hiding this comment.
~50ish items. - I agree that this is not ideal but I don't think there are any other hints then the name and the date to match an item with an invoice, and considering that this gets only called once when they open a specific item this should not be too big of a problem. But it would be great if someone with a large hangar could test the performance.
| // TODO should this be place somewhere else? - it just needs to be done before we process the items | ||
| // so that we have the billing data already in order to link to it | ||
| HangarXPLOR.Billing.LoadData(); |
There was a problem hiding this comment.
If we're only linking to billing data - perhaps the lookup could be executed on-click rather than pre-loaded?
Might help with larger hangars/billing history
EDIT: I see in ProcessItem you may already be doing this.
There was a problem hiding this comment.
Correct. The look up happens when you click the arrow button to open up each item. The look ups should also always be fairly fast unless the user has a lot of bills on one specific day.
- remove invoice link for items that have no value - fix: always search for the name - find invocie for upgraded items
|
I have made a few changes in this commit. At one point in the code, I simply checked if only one bill exists at a given date and if so I would simply return that bill. That is not correct since CIG sometimes hands out items for special occasions without generating an invoice, so if you buy an item on the same day it would have also shown that bill for the free item. Now I always search to see if the name matches. |
As requested in #16 I have added the first iteration of this feature. It is still fairly buggy and needs some more work. Right now it just opens the PDF of the invoice when you click the "Retrive Invoice" button.
The biggest issue is figuring out what bill belongs to which item. Right now, I parse the date of the bills and the dates of the items and when there is only one match for each date then that bill is assigned to that item. If there are more matches then I try to compare names but that doesn't always work, so this issue will work really poorly for people who have a lot of bills on a single day. Furthermore, I somehow broke some boxes and you cannot open.
So this PR is still very much a WIP but it already is in a state where it kinda works. So definitely don't merge this just yet.
(When the PDF window opens it is bigger than that but I made it smaller to hide some personal details :))